Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapting replace_plots.pl to get plot id #4774

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Adapting replace_plots.pl to get plot id #4774

merged 1 commit into from
Jan 9, 2024

Conversation

chris263
Copy link
Contributor

@chris263 chris263 commented Jan 2, 2024

Description

With this change plot_id is not required field anymore, just have to add plot name (it is easier to find).

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@chris263 chris263 requested review from lukasmueller and isaak January 2, 2024 18:12
lukasmueller
lukasmueller reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this script used anywhere in the system?

@lukasmueller
Copy link
Member

it doesn't not seem to be used anywhere.

lukasmueller
lukasmueller approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@lukasmueller lukasmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit 1a87434 into master Jan 9, 2024
1 check passed
@lukasmueller lukasmueller deleted the topic/replace_accession_in_plot branch January 9, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmueller lukasmueller lukasmueller approved these changes

@isaak isaak isaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris263 @lukasmueller @isaak