Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show non numeric traits and trait raw data on trait detail page #4739

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Show non numeric traits and trait raw data on trait detail page #4739

merged 10 commits into from
Jan 9, 2024

Conversation

lukasmueller
Copy link
Member

Description

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

alockrow
alockrow requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@alockrow alockrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for raw being written twice in the section description. I also wasn't able to find any non-numeric data to test it on. Also of note: the smiley shows up while the page is loading; not sure if that matters at all.

@nmenda
Copy link
Member

nmenda commented Dec 1, 2023

I still see only the first 10 traits in the 'phenotype raw data' section

@lukasmueller
Copy link
Member Author

I think I fixed the issue with the limited traits in the menu by moving the pageSize argument to the correct location in the ajax call.

darekbienkowski
darekbienkowski approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@darekbienkowski darekbienkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;-)

nmenda
nmenda approved these changes Jan 4, 2024
View reviewed changes
mason/breeders_toolbox/trial/trial_raw_data.mas Outdated

<h3>Select Trait</h3>

<div id="trait_selector_for_raw_data">:-)</div><br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe replace this with "Loading..." ?

@lukasmueller lukasmueller merged commit 5b89ae5 into master Jan 9, 2024
1 check passed
@lukasmueller lukasmueller deleted the topic/show_non_numeric_traits branch January 9, 2024 04:20
@lukasmueller lukasmueller mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmenda nmenda nmenda approved these changes

@darekbienkowski darekbienkowski darekbienkowski approved these changes

@alockrow alockrow alockrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukasmueller @nmenda @darekbienkowski @alockrow