From 3ba25b0a3cb8afb0390664f67b141a56544e2bfe Mon Sep 17 00:00:00 2001 From: Clay Birkett Date: Wed, 26 Feb 2025 11:00:24 -0500 Subject: [PATCH] clean up warnings --- lib/solGS/JobSubmission.pm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/solGS/JobSubmission.pm b/lib/solGS/JobSubmission.pm index b7a7b529a1..078d8937a4 100644 --- a/lib/solGS/JobSubmission.pm +++ b/lib/solGS/JobSubmission.pm @@ -72,15 +72,16 @@ sub run_prerequisite_jobs { $remaining_jobs = $self->wait_till_jobs_end($submitted_priority_jobs); } else { - if ( reftype $pre_jobs eq 'SCALAR' ) { + if ( reftype($pre_jobs) eq 'SCALAR' ) { $pre_jobs = [$pre_jobs]; } my $submitted_jobs = $self->submit_jobs($pre_jobs); $remaining_jobs = $self->wait_till_jobs_end($submitted_jobs); - print STDERR "\nremaining jobs: $remaining_jobs\n"; - + if (defined $remaining_jobs) { + print STDERR "\nremaining jobs: $remaining_jobs\n"; + } } } @@ -126,14 +127,16 @@ sub run_dependent_jobs { my $jobs_file = $self->dependent_jobs; my $dep_jobs = retrieve($jobs_file); - if ( reftype $dep_jobs ne 'ARRAY' ) { + if ( reftype($dep_jobs) ne 'ARRAY' ) { $dep_jobs = [$dep_jobs]; } my $submitted_jobs = $self->submit_jobs($dep_jobs); my $remaining_jobs = $self->wait_till_jobs_end($submitted_jobs); - print STDERR "\nremaining jobs: $remaining_jobs\n"; + if (defined $remaining_jobs) { + print STDERR "\nremaining jobs: $remaining_jobs\n"; + } return $remaining_jobs; }