Skip to content

Commit 6dae856

Browse files
Minor documentation fixes and tweaks.
1 parent 1e5a99e commit 6dae856

File tree

5 files changed

+49
-48
lines changed

5 files changed

+49
-48
lines changed

doc/demo.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ Windows Statically linked OpenSSL Statically linked OpenSSL
4747
======== ================================== ===================================
4848

4949
Before building the demo you must first populate the ``src`` directory with
50-
appropriate source archives for the following packages:
50+
appropriate source archives for the following components:
5151

5252
- Python
5353
- Qt

doc/introduction.rst

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ file.
4747

4848
Another companion program :program:`pyqtdeploy-sysroot` provides support for
4949
creating a system root directory containing target-specific installations of
50-
certain packages (e.g. Python itself and PyQt).
50+
certain components (e.g. Python itself and PyQt).
5151

5252
.. note::
5353

@@ -65,20 +65,20 @@ There have been a number of changes to :program:`pyqtdeploy` since v1. Most of
6565
these changes are related to the supporting tools rather than the GUI. Project
6666
files created for v1 are automatically updated by later versions.
6767

68-
Python v3.6 or later is required for Android targets, support for earlier
69-
versions has been removed.
68+
Python v3.6 or later is required for Android, support for earlier versions has
69+
been removed.
7070

7171
v1 recommended a directory structure to adopt when assembling the various parts
7272
of a deployable application. This was refered to as the *sysroot* directory.
7373
An unsupported script, :program:`build-sysroot.py`, was provided that created
7474
the sysroot directory and was able to build and install a limited number of
75-
packages - mainly PyQt and related packages. It used configuration files
76-
generated by the :program:`pyqtdeploycli` program to specify how those packages
77-
were built, e.g. which individual modules and features were enabled.
75+
components - mainly PyQt and related packages. It used configuration files
76+
generated by the :program:`pyqtdeploycli` program to specify how those
77+
components were built, e.g. which individual modules and features were enabled.
7878
:program:`build-sysroot.py` has been replaced with the fully supported
79-
:program:`pyqtdeploy-sysroot` program. Individual package support is
80-
implemented by a configurable package plugin. An API is provided for you to
81-
write (and contribute) your own plugins for additional packages. As with v1,
79+
:program:`pyqtdeploy-sysroot` program. Individual component support is
80+
implemented by a configurable component plugin. An API is provided for you to
81+
write (and contribute) your own plugins for additional components. As with v1,
8282
using the sysroot directory structure is entirely optional.
8383

8484
The :program:`pyqtdeploycli` program has been removed. The build functionality
@@ -101,7 +101,7 @@ Author
101101
homepage is https://www.riverbankcomputing.com/software/pyqtdeploy/.
102102

103103
Support may be obtained from the PyQt mailing list at
104-
https://www.riverbankcomputing.com/mailman/listinfo/pyqt
104+
https://www.riverbankcomputing.com/mailman/listinfo/pyqt/.
105105

106106

107107
License

doc/overview.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ by a ``-``. Note that not all platform/word size combinations are supported.
2929
- :program:`qmake` is the Qt build system that supports cross-compilation to
3030
multiple targets.
3131

32-
- :program:`rcc` is a utility that converts arbitrary files in C++ code that
33-
implements an embedded filesystem that can be linked as part of an
34-
application.
32+
- :program:`rcc` is a utility that converts arbitrary files to C++ data
33+
structures that implement an embedded filesystem that can be linked as part
34+
of an application.
3535

3636
- The :program:`QtCore` library implements file access APIs that recognise file
3737
and directory names that refer to the contents of the embedded filesystem
@@ -40,7 +40,7 @@ by a ``-``. Note that not all platform/word size combinations are supported.
4040
the embedded filesystem just as if they were being imported from an ordinary
4141
filesystem.
4242

43-
Note that :program:`pyqtdeploy` does not itself use PyQt.
43+
Note that :program:`pyqtdeploy` generated code does not itself use PyQt.
4444
:program:`pyqtdeploy` can be used to deploy non-PyQt applications, including
4545
simple command line scripts. However, as every deployed application is linked
4646
with the :program:`QtCore` library, you should make sure that you application's

doc/pyqtdeploy.rst

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
Creating a :program:`pyqtdeploy` Project
66
========================================
77

8-
The first stage of deploying a PyQt application is to create a
8+
The next stage of deploying a PyQt application is to create a
99
:program:`pyqtdeploy` project for it by running::
1010

1111
pyqtdeploy pyqt-demo.pdy
@@ -125,7 +125,7 @@ The tab for defining the application source is shown below.
125125
enabled.
126126

127127
**Target Python version**
128-
is used to specify version of Python that you are targetting.
128+
is used to specify version of Python that you are targeting.
129129

130130
**Target PyQt version**
131131
is used to specify that the application is either a PyQt4 or a PyQt5
@@ -245,8 +245,8 @@ application is shown below.
245245

246246
- *checked* meaning it is explicitly imported by the application
247247
- *partially checked* meaning it is implicitly imported by the application
248-
because an explicitly imported package depends on it, or the Python
249-
interpreter itself imports it
248+
because another imported package depends on it, or the Python interpreter
249+
itself imports it
250250
- *unchecked* meaning it is not needed by the application.
251251

252252
You should always check a package if the application explicitly imports it,
@@ -259,7 +259,7 @@ application is shown below.
259259
:mod:`subprocess` modules (amongst others) have been partially checked
260260
automatically.
261261

262-
The remaining part of the tab relates to non-system libraries that may need to
262+
The remaining part of the tab relates to additional libraries that may need to
263263
be linked with the application. Typically they correspond to packages in the
264264
standard library that wrap them. A tab is provided for each target platform so
265265
that a library can be handled in a platform-specific manner. If a library is
@@ -268,8 +268,8 @@ library will be enabled. The corresponding ``DEFINES``, ``INCLUDEPATH`` and
268268
``LIBS`` fields will also be editable allowing those values to be set
269269
appropriately. If all of those fields are left blank then the external library
270270
is effectively disabled. This can be useful if, for example, the original
271-
Python package is written to use an external library if it is available but to
272-
fall back to another implementation if not.
271+
Python package is written to use an external library if it is available but
272+
will fall back to another implementation if not.
273273

274274
For example, if you have built a static copy of the library
275275
then you may need to specify the location of the library's header files in the
@@ -381,15 +381,15 @@ project files that can be used without modification across all supported
381381
targets. To this end the values of these :program:`qmake` variables may be
382382
*scoped* with any supported target architecture or platform name.
383383

384-
The scope is specified immediately before the value and separated by a ``#``.
385-
A scope can take one of the following forms (where *target* is either a target
386-
architecture or platform):
384+
The scope is specified immediately before the value and separated from it by a
385+
``#``. A scope can take one of the following forms (where *target* is either a
386+
target architecture or platform):
387387

388388
- *target* where the value applies for the specified target only
389389

390390
- *!target* where the values applies to all targets except the one specified
391391

392-
- *target|target* where the value applies to all of the targets specified.
392+
- *target|target|...* where the value applies to all of the targets specified.
393393

394394
The most common requirement is to distinguish between Windows and non-Windows
395395
targets, therefore the most common scopes used will be ``win`` and ``!win``.
@@ -444,7 +444,7 @@ The tab for defining the locations of various files and directories needed by
444444
:program:`pyqtdeploy` will interpret it correctly on Windows. It can be
445445
overridden by the
446446
:option:`--python-library <pyqtdeploy-build --python-library>` command line
447-
option of :program:`pyqtdeploycli`.
447+
option of :program:`pyqtdeploy-build`.
448448

449449
**Standard library directory**
450450
is used to specify the name of the directory containing the target Python

doc/sysroot.rst

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ The following component plugins are included as standard with
4444
installed on :envvar:`PATH`.
4545

4646
**pip**
47-
This is a meta-component which can install any number of components that
47+
This is a meta-component which will install any number of components that
4848
can be installed by ``pip``.
4949

5050
**pyqt3d**
@@ -154,7 +154,7 @@ The Python binary installer for macOS from `www.python.org <www.python.org>`__
154154
includes a patched version of OpenSSL. The plugin will apply the same patch to
155155
OpenSSL (on macOS only) if a Python source archive is specified. The patch
156156
applies to a specific version of OpenSSL - which one depends on the version of
157-
Python.
157+
Python being targeted.
158158

159159

160160
qt5
@@ -200,8 +200,8 @@ the MSVC runtime libraries.
200200

201201
For simplicity we have chosen to build a full Qt implementation when building
202202
from source. We could have chosen to use the ``configure_options``,
203-
``disabled_features`` and ``skip`` attributes to tailor the Qt build into to
204-
reduce the time taken to do the build.
203+
``disabled_features`` and ``skip`` attributes to tailor the Qt build in order
204+
to reduce the time taken to do the build.
205205

206206

207207
python
@@ -216,11 +216,11 @@ python
216216
},
217217

218218
The Python component plugin handles installation for both host and target
219-
architectures. For the host we choose to use an existing Python installation.
220-
On Windows the registry is searched for the location of the existing
221-
installation. On Linux and macOS the Python interpreter must be on
222-
:envvar:`PATH`. For all target architecures we choose to build Python from
223-
source.
219+
architectures. For the host we choose to use an existing Python installation
220+
rather than build from source. On Windows the registry is searched for the
221+
location of the existing installation. On Linux and macOS the Python
222+
interpreter must be on :envvar:`PATH`. For all target architecures we choose
223+
to build Python from source.
224224

225225
:program:`pyqt-demo` is a very simple application that does not need to
226226
dynamically load extension modules. If this was needed then the
@@ -284,8 +284,8 @@ The two attributes used to tailor the build of PyQt5 are ``disabled_features``
284284
and ``modules``.
285285

286286
Unfortunately the list of features that can be disabled is not properly
287-
documented and relate to how Qt5 was configured. However how the attribute is
288-
set in the above will be appropriate for most cases.
287+
documented and relate to how Qt5 was configured. However how
288+
``disabled_features`` is set in the above will be appropriate for most cases.
289289

290290
The ``modules`` attribute is used to specify the names of the individual PyQt
291291
extension modules to be built. We choose to build only those extension
@@ -373,7 +373,7 @@ The full set of command line options is:
373373
A temporary build directory (called ``build`` in the sysroot) is created in
374374
order to build the required components. Normally this is removed
375375
automatically after all components have been built. Specifying this option
376-
leaves the build directory as it is to make debugging component plugins
376+
leaves the build directory in place to make debugging component plugins
377377
easier.
378378

379379
.. option:: --options
@@ -386,8 +386,8 @@ The full set of command line options is:
386386
``DIR`` is added to the list of directories that are searched for component
387387
plugins. It may be used more than once to search multiple directories.
388388
All directories specified in this way will be searched before those
389-
directories (internal to :program:`pyqtdeploy-sysroot`) searched by
390-
default.
389+
directories (internal to :program:`pyqtdeploy-sysroot`) that are searched
390+
by default.
391391

392392
.. option:: --source-dir DIR
393393

@@ -516,12 +516,13 @@ class is.
516516
.. py:method:: copy_dir(src, dst, ignore=None)
517517
518518
A directory is copied, optionally excluding file and sub-directories
519-
that match a number of patterns. If the destination directory already
520-
exists then it is first removed. Any errors are handled automatically.
519+
that match a number of glob patterns. If the destination directory
520+
already exists then it is first removed. Any errors are handled
521+
automatically.
521522

522523
:param str src: is the name of the source directory.
523524
:param str dst: is the name of the destination directory.
524-
:param list[str] ignore: is an optional sequence of patterns that
525+
:param list[str] ignore: is an optional sequence of glob patterns that
525526
specify files and sub-directories that should be ignored.
526527

527528
.. py:method:: create_file(name)
@@ -538,13 +539,13 @@ class is.
538539
already exist then it is optionally emptied. Any errors are handled
539540
automatically.
540541

541-
:param str name: is the name of the directory
542+
:param str name: is the name of the directory.
542543
:param bool empty: ``True`` if an existing directory should be emptied.
543544

544545
.. py:method:: decode_version_nr(version_nr)
545546
546547
An encoded version number is decoded to a 3-tuple of major version,
547-
minor version and maintenance version.
548+
minor version and patch version.
548549

549550
:param int version_nr: is the encoded version number.
550551
:return: the decoded 3-tuple.
@@ -686,7 +687,7 @@ class is.
686687
687688
Convert a string in the form [M[.m[.p]]] to an encoded version number.
688689

689-
:param str version_str] is the version number to parse.
690+
:param str version_str: is the version number to parse.
690691
:return: an encoded version number.
691692

692693
.. py:method:: pip_install(package)
@@ -779,7 +780,7 @@ class is.
779780

780781
.. py:method:: unpack_archive(archive, chdir=True)
781782
782-
An archive (i.e. a ``.tar.gz`` or ``.zip`` file) is unpacked in the
783+
An archive (e.g. a ``.tar.gz`` or ``.zip`` file) is unpacked in the
783784
current directory.
784785

785786
:param str archive: the name of the archive.

0 commit comments

Comments
 (0)