Add tests

Author: AshwinSekar

core/src/banking_stage.rs

@@ -6,7 +6,9 @@ use {
     crate::{
         forward_packet_batches_by_accounts::ForwardPacketBatchesByAccounts,
         immutable_deserialized_packet::ImmutableDeserializedPacket,
-        latest_unprocessed_votes::{self, DeserializedVotePacket, LatestUnprocessedVotes, VoteSource},
+        latest_unprocessed_votes::{
+            self, DeserializedVotePacket, LatestUnprocessedVotes, VoteSource,
+        },
         leader_slot_banking_stage_metrics::{LeaderSlotMetricsTracker, ProcessTransactionsSummary},
         leader_slot_banking_stage_timing_metrics::{
             LeaderExecuteAndCommitTimings, RecordTransactionsTimings,
@@ -1234,14 +1236,12 @@ impl BankingStage {
         bank_forks: &Arc<RwLock<BankForks>>,
     ) {
         let forward_option = unprocessed_transaction_storage.forward_option();
-        // The gossip thread should not even reach this point
-        assert!(!matches!(forward_option, ForwardOption::NotForward));
 
         // get current root bank from bank_forks, use it to sanitize transaction and
         // load all accounts from address loader;
         let current_bank = bank_forks.read().unwrap().root_bank();
         let mut forward_packet_batches_by_accounts =
-            ForwardPacketBatchesByAccounts::new_with_default_batch_limits(current_bank.clone());
+            ForwardPacketBatchesByAccounts::new_with_default_batch_limits(current_bank);
         let filter_forwarding_result = unprocessed_transaction_storage
             .filter_forwardable_packets_and_add_batches(&mut forward_packet_batches_by_accounts);
 
@@ -2494,6 +2494,9 @@ mod tests {
         },
         solana_streamer::{recvmmsg::recv_mmsg, socket::SocketAddrSpace},
         solana_transaction_status::{TransactionStatusMeta, VersionedTransactionWithStatusMeta},
+        solana_vote_program::{
+            vote_state::VoteStateUpdate, vote_transaction::new_vote_state_update_transaction,
+        },
         std::{
             borrow::Cow,
             collections::HashSet,
@@ -4730,4 +4733,71 @@ mod tests {
         BankingStage::filter_processed_packets(retryable_indexes.iter(), f);
         assert_eq!(non_retryable_indexes, vec![(0, 1), (4, 5), (6, 8)]);
     }
+
+    #[test]
+    fn test_unprocessed_transaction_storage_deserialize_and_insert() {
+        let keypair = Keypair::new();
+        let vote_keypair = Keypair::new();
+        let pubkey = solana_sdk::pubkey::new_rand();
+
+        let small_transfer = Packet::from_data(
+            None,
+            system_transaction::transfer(&keypair, &pubkey, 1, Hash::new_unique()),
+        )
+        .unwrap();
+        let mut vote = Packet::from_data(
+            None,
+            new_vote_state_update_transaction(
+                VoteStateUpdate::default(),
+                Hash::new_unique(),
+                &keypair,
+                &vote_keypair,
+                &vote_keypair,
+                None,
+            ),
+        )
+        .unwrap();
+        vote.meta.flags.set(PacketFlags::SIMPLE_VOTE_TX, true);
+        let big_transfer = Packet::from_data(
+            None,
+            system_transaction::transfer(&keypair, &pubkey, 1000000, Hash::new_unique()),
+        )
+        .unwrap();
+
+        let packet_batch = PacketBatch::new(vec![
+            small_transfer.clone(),
+            vote.clone(),
+            big_transfer.clone(),
+        ]);
+
+        for thread_type in [
+            ThreadType::Transactions,
+            ThreadType::Voting(VoteSource::Gossip),
+            ThreadType::Voting(VoteSource::Tpu),
+        ] {
+            let mut transaction_storage = UnprocessedTransactionStorage::TransactionStorage(
+                UnprocessedPacketBatches::with_capacity(100),
+                thread_type,
+            );
+            transaction_storage
+                .deserialize_and_insert_batch(&packet_batch, &(0..3 as usize).collect_vec());
+            let deserialized_packets = transaction_storage
+                .iter()
+                .map(|packet| packet.immutable_section().original_packet().clone())
+                .collect_vec();
+            assert_eq!(3, deserialized_packets.len());
+            assert!(deserialized_packets.contains(&small_transfer));
+            assert!(deserialized_packets.contains(&vote));
+            assert!(deserialized_packets.contains(&big_transfer));
+        }
+
+        for vote_source in [VoteSource::Gossip, VoteSource::Tpu] {
+            let mut transaction_storage = UnprocessedTransactionStorage::VoteStorage(
+                Arc::new(LatestUnprocessedVotes::new()),
+                vote_source,
+            );
+            transaction_storage.deserialize_and_insert_batch(&packet_batch, &(0..3 as usize).collect_vec());
+            assert_eq!(1, transaction_storage.len());
+        }
+    }
 }