Skip to content

Commit 8e01761

Browse files
committed
fix: don't pass --silent to package installation with verbose enabled
1 parent 3c06fb4 commit 8e01761

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/utils/create-app-task-install-dependencies.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { getPackageManagerCommand } from './vendor/package-manager'
88

99
export function createAppTaskInstallDependencies(args: GetArgsResult): Task {
1010
const pm = args.packageManager
11-
const { install, lockFile } = getPackageManagerCommand(pm)
11+
const { install, lockFile } = getPackageManagerCommand(pm, args.verbose)
1212
return {
1313
enabled: !args.skipInstall,
1414
title: `Installing via ${pm}`,

src/utils/vendor/package-manager.ts

+8-4
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ export function detectInvokedPackageManager(): PackageManager {
4545
* ```
4646
*
4747
*/
48-
export function getPackageManagerCommand(packageManager: PackageManager = detectPackageManager()): {
48+
export function getPackageManagerCommand(
49+
packageManager: PackageManager = detectPackageManager(),
50+
verbose: boolean,
51+
): {
4952
install: string
5053
exec: string
5154
preInstall?: string
@@ -56,11 +59,12 @@ export function getPackageManagerCommand(packageManager: PackageManager = detect
5659
} {
5760
const pmVersion = getPackageManagerVersion(packageManager)
5861
const [pmMajor, pmMinor] = pmVersion.split('.')
62+
const silent = verbose ? '' : '--silent'
5963

6064
switch (packageManager) {
6165
case 'yarn': {
6266
const useBerry = +pmMajor >= 2
63-
const installCommand = 'yarn install --silent'
67+
const installCommand = `yarn install ${silent}`
6468
return {
6569
preInstall: `yarn set version ${pmVersion}`,
6670
install: useBerry ? installCommand : `${installCommand} --ignore-scripts`,
@@ -78,7 +82,7 @@ export function getPackageManagerCommand(packageManager: PackageManager = detect
7882
useExec = true
7983
}
8084
return {
81-
install: 'pnpm install --no-frozen-lockfile --silent --ignore-scripts',
85+
install: `pnpm install --no-frozen-lockfile ${silent} --ignore-scripts`,
8286
exec: useExec ? 'pnpm exec' : 'pnpx',
8387
globalAdd: 'pnpm add -g',
8488
getRegistryUrl: 'pnpm config get registry',
@@ -88,7 +92,7 @@ export function getPackageManagerCommand(packageManager: PackageManager = detect
8892

8993
case 'npm': {
9094
return {
91-
install: 'npm install --silent --ignore-scripts',
95+
install: `npm install ${silent} --ignore-scripts`,
9296
exec: 'npx',
9397
globalAdd: 'npm i -g',
9498
getRegistryUrl: 'npm config get registry',

0 commit comments

Comments
 (0)