Skip to content

Commit 2401b65

Browse files
author
Krzysztof Wojnar
committed
chore(e2e): review suggestions applied
1 parent 803b1d3 commit 2401b65

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

Example/e2e/examplesTests/bottomTabs.e2e.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { device, expect, element, by } from 'detox';
22

33
describe('Bottom tabs and native stack', () => {
44
beforeEach(async () => {
5-
await device.reloadReactNative();
65
await device.launchApp({ newInstance: true });
76
});
87

Example/e2e/examplesTests/events.e2e.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ const awaitClassicalEventBehavior = async () => {
3636

3737
describe('Events', () => {
3838
beforeEach(async () => {
39-
await device.reloadReactNative();
4039
await device.launchApp({ newInstance: true });
4140

4241
await waitFor(element(by.id('root-screen-playground-Events')))

FabricExample/e2e/component-objects/back-button.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { getIOSVersion } from '../../../scripts/e2e/ios-devices.js';
33
import semverSatisfies from 'semver/functions/satisfies';
44
import semverCoerce from 'semver/functions/coerce';
55

6+
const IOS_BAR_BUTTON_TYPE = '_UIButtonBarButton';
67
const backButtonElement = element(by.id('BackButton'));
78

89
export async function tapBarBackButton() {
@@ -22,9 +23,12 @@ async function getIOSBackButton() {
2223
};
2324
const elements = elementsByAttributes.elements;
2425
if (Array.isArray(elements)) {
25-
return backButtonElement.atIndex(
26-
elements.findIndex(elem => elem.className === '_UIButtonBarButton'),
26+
const uiBarButtonIndex = elements.findIndex(
27+
elem => elem.className === IOS_BAR_BUTTON_TYPE,
2728
);
29+
if (uiBarButtonIndex !== -1) {
30+
return backButtonElement.atIndex(uiBarButtonIndex);
31+
}
2832
}
2933
}
3034
return backButtonElement;

0 commit comments

Comments
 (0)