Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires() helper does not always support context correctly #66

Closed
notmessenger opened this issue Feb 19, 2015 · 2 comments
Closed

requires() helper does not always support context correctly #66

notmessenger opened this issue Feb 19, 2015 · 2 comments
Assignees
Milestone

Comments

@notmessenger
Copy link
Collaborator

Attempting to replace the testing code at
https://github.com/softlayer/sl-ember-translate/blob/923c681ba54cf65e46f7280b0fb65c6b13f24495/tests/unit/services/translate-test.js#L25-110 with

var test = requires( TS.setDictionary, [ 'object' ] );
assert.ok( test.requires, test.messages );

"this" does not exist (https://github.com/softlayer/sl-ember-translate/blob/e6666ff06ad6959600f60f9c0fe5bb1c840527f7/addon/services/translate.js#L51)

@notmessenger
Copy link
Collaborator Author

@notmessenger
Copy link
Collaborator Author

Will be resolved by #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants