Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support uninstall of add on #1

Open
notmessenger opened this issue Nov 20, 2014 · 2 comments
Open

Support uninstall of add on #1

notmessenger opened this issue Nov 20, 2014 · 2 comments
Labels
enhancement

Comments

@notmessenger
Copy link
Collaborator

This add on uses afterInstall() to call insertIntoFile() to modify some files. Uninstalling this add on should reverse these changes.

As there is not a companion method to insertIntoFile() to remove entries from a file consider either adding one to Ember CLI or build something only into this add on (prefer the former over the latter). https://github.com/stefanpenner/ember-cli/blob/8c75ab70b71c6668e1c024a160fa425f344c6993/blueprints/route/index.js#L76 is precedence for such need.
azizpunjani pushed a commit to azizpunjani/sl-ember-test-helpers that referenced this issue Dec 7, 2015
@theoshu
Merge pull request softlayer#1 from azizpunjani/issue156
aa4a74d 
Changed API interface a little to accomodate for event firing
@notmessenger notmessenger mentioned this issue Dec 14, 2015
Open
@notmessenger
Copy link
Collaborator Author

Will likely be addressed by #159

@notmessenger
Copy link
Collaborator Author

Is this of any inspiration? ember-cli/ember-cli#2748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notmessenger