Skip to content

Commit 915825f

Browse files
committed
fix unit tests
1 parent 27ecf89 commit 915825f

File tree

14 files changed

+25
-38
lines changed

14 files changed

+25
-38
lines changed

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@
255255
<dependency>
256256
<groupId>org.mockito</groupId>
257257
<artifactId>mockito-core</artifactId>
258-
<version>1.10.19</version>
258+
<version>4.3.0</version>
259259
<scope>test</scope>
260260
</dependency>
261261
<dependency>

sofa-tracer-plugins/sofa-tracer-datasource-plugin/pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
<dependency>
3838
<groupId>org.mockito</groupId>
3939
<artifactId>mockito-core</artifactId>
40-
<version>2.10.0</version>
4140
<scope>test</scope>
4241
</dependency>
4342
<dependency>

sofa-tracer-plugins/sofa-tracer-datasource-plugin/src/test/java/com/sofa/tracer/plugins/datasource/base/BaseTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import org.junit.runner.RunWith;
3232
import org.junit.runners.MethodSorters;
3333
import org.mockito.Mock;
34-
import org.mockito.runners.MockitoJUnitRunner;
34+
import org.mockito.junit.MockitoJUnitRunner;
3535

3636
import javax.sql.DataSource;
3737
import java.io.File;

sofa-tracer-plugins/sofa-tracer-kafkamq-plugin/pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
<dependency>
4646
<groupId>org.mockito</groupId>
4747
<artifactId>mockito-core</artifactId>
48-
<version>2.10.0</version>
4948
<scope>test</scope>
5049
</dependency>
5150
<dependency>

sofa-tracer-plugins/sofa-tracer-rabbitmq-plugin/pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
<dependency>
4646
<groupId>org.mockito</groupId>
4747
<artifactId>mockito-core</artifactId>
48-
<version>2.10.0</version>
4948
<scope>test</scope>
5049
</dependency>
5150
<dependency>

tracer-core/src/test/java/com/alipay/common/tracer/core/benchmark/CountBenchmark.java

-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.alipay.common.tracer.core.benchmark;
1818

1919
import com.alipay.common.tracer.core.utils.StringUtils;
20-
import org.junit.Test;
2120
import org.openjdk.jmh.annotations.Benchmark;
2221
import org.openjdk.jmh.annotations.BenchmarkMode;
2322
import org.openjdk.jmh.annotations.Mode;
@@ -77,7 +76,6 @@ public void countUseCountMatches(Blackhole blackhole) {
7776
blackhole.consume(StringUtils.countMatches(RPC_ID, '.'));
7877
}
7978

80-
@Test
8179
public static void main(String[] args) throws RunnerException {
8280
Options opt = new OptionsBuilder().include(CountBenchmark.class.getSimpleName()).forks(1)
8381
.build();

tracer-sofa-boot-starter/pom.xml

+10-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@
1717
</properties>
1818

1919
<dependencies>
20+
<dependency>
21+
<groupId>com.alipay.sofa</groupId>
22+
<artifactId>sofa-boot</artifactId>
23+
</dependency>
2024
<dependency>
2125
<groupId>com.alipay.sofa</groupId>
2226
<artifactId>tracer-core</artifactId>
@@ -259,13 +263,18 @@
259263
<dependency>
260264
<groupId>de.flapdoodle.embed</groupId>
261265
<artifactId>de.flapdoodle.embed.mongo</artifactId>
262-
<version>2.2.0</version>
263266
<scope>test</scope>
264267
</dependency>
265268
<dependency>
266269
<groupId>cz.jirutka.spring</groupId>
267270
<artifactId>embedmongo-spring</artifactId>
268271
<version>1.3.1</version>
272+
<optional>true</optional>
273+
</dependency>
274+
275+
<dependency>
276+
<groupId>junit</groupId>
277+
<artifactId>junit</artifactId>
269278
<scope>test</scope>
270279
</dependency>
271280
</dependencies>

tracer-sofa-boot-starter/src/main/java/com/alipay/sofa/tracer/boot/listener/SofaTracerConfigurationListener.java

+2-18
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import com.alipay.common.tracer.core.configuration.SofaTracerConfiguration;
2020
import com.alipay.common.tracer.core.utils.StringUtils;
21+
import com.alipay.sofa.boot.util.SofaBootEnvUtils;
2122
import com.alipay.sofa.tracer.boot.properties.SofaTracerProperties;
2223
import org.springframework.boot.context.event.ApplicationEnvironmentPreparedEvent;
2324
import org.springframework.boot.context.properties.ConfigurationProperties;
@@ -27,9 +28,7 @@
2728
import org.springframework.core.Ordered;
2829
import org.springframework.core.annotation.AnnotationUtils;
2930
import org.springframework.core.env.ConfigurableEnvironment;
30-
import org.springframework.core.env.Environment;
3131
import org.springframework.util.Assert;
32-
import org.springframework.util.ClassUtils;
3332

3433
/**
3534
* Parse SOFATracer Configuration in early stage.
@@ -46,7 +45,7 @@ public class SofaTracerConfigurationListener
4645
public void onApplicationEvent(ApplicationEnvironmentPreparedEvent event) {
4746
ConfigurableEnvironment environment = event.getEnvironment();
4847

49-
if (isSpringCloudBootstrapEnvironment(environment)) {
48+
if (SofaBootEnvUtils.isSpringCloudBootstrapEnvironment(environment)) {
5049
return;
5150
}
5251

@@ -112,19 +111,4 @@ public void onApplicationEvent(ApplicationEnvironmentPreparedEvent event) {
112111
public int getOrder() {
113112
return HIGHEST_PRECEDENCE + 30;
114113
}
115-
116-
private boolean isSpringCloudBootstrapEnvironment(Environment environment) {
117-
if (!(environment instanceof ConfigurableEnvironment)) {
118-
return false;
119-
} else {
120-
return !((ConfigurableEnvironment) environment).getPropertySources().contains(
121-
"sofaBootstrap")
122-
&& isSpringCloud();
123-
}
124-
}
125-
126-
private boolean isSpringCloud() {
127-
return ClassUtils.isPresent("org.springframework.cloud.bootstrap.BootstrapConfiguration",
128-
null);
129-
}
130114
}

tracer-sofa-boot-starter/src/test/java/com/alipay/sofa/tracer/boot/base/AbstractTestBase.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import com.alipay.common.tracer.core.reporter.digest.manager.SofaTracerDigestReporterAsyncManager;
2222
import com.alipay.common.tracer.core.reporter.stat.manager.SofaTracerStatisticReporterCycleTimesManager;
2323
import com.alipay.common.tracer.core.reporter.stat.manager.SofaTracerStatisticReporterManager;
24-
import com.alipay.sofa.infra.listener.SofaBootstrapRunListener;
24+
import com.alipay.sofa.boot.listener.SofaBootstrapRunListener;
2525
import com.alipay.sofa.tracer.plugins.springmvc.SpringMvcTracer;
2626
import org.apache.commons.io.FileUtils;
2727
import org.junit.AfterClass;

tracer-sofa-boot-starter/src/test/java/com/alipay/sofa/tracer/boot/base/AbstractTestCloudBase.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import com.alipay.common.tracer.core.appender.TracerLogRootDaemon;
2020
import com.alipay.common.tracer.core.configuration.SofaTracerConfiguration;
21-
import com.alipay.sofa.infra.listener.SofaBootstrapRunListener;
21+
import com.alipay.sofa.boot.listener.SofaBootstrapRunListener;
2222
import org.apache.commons.io.FileUtils;
2323
import org.junit.AfterClass;
2424
import org.junit.BeforeClass;
@@ -41,7 +41,7 @@
4141
@RunWith(SpringJUnit4ClassRunner.class)
4242
@SpringBootTest(classes = SpringBootWebApplication.class, webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT)
4343
@TestPropertySource(locations = "classpath:application.properties")
44-
public class AbstractTestCloudBase {
44+
public abstract class AbstractTestCloudBase {
4545
protected static String logDirectoryPath = TracerLogRootDaemon.LOG_FILE_DIR;
4646

4747
@BeforeClass

tracer-sofa-boot-starter/src/test/java/com/alipay/sofa/tracer/boot/base/ConfigurationHolderListener.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import com.alipay.common.tracer.core.configuration.SofaTracerConfiguration;
2020
import com.alipay.common.tracer.core.utils.StringUtils;
21-
import com.alipay.sofa.infra.utils.SOFABootEnvUtils;
21+
import com.alipay.sofa.boot.util.SofaBootEnvUtils;
2222
import com.alipay.sofa.tracer.boot.properties.SofaTracerProperties;
2323
import org.springframework.boot.context.event.ApplicationEnvironmentPreparedEvent;
2424
import org.springframework.context.ApplicationListener;
@@ -33,7 +33,7 @@ public class ConfigurationHolderListener implements
3333
@Override
3434
public void onApplicationEvent(ApplicationEnvironmentPreparedEvent event) {
3535
ConfigurableEnvironment environment = event.getEnvironment();
36-
if (SOFABootEnvUtils.isSpringCloudBootstrapEnvironment(environment)) {
36+
if (SofaBootEnvUtils.isSpringCloudBootstrapEnvironment(environment)) {
3737
return;
3838
}
3939
SofaTracerProperties sofaTracerProperties = new SofaTracerProperties();

tracer-sofa-boot-starter/src/test/java/com/alipay/sofa/tracer/boot/base/SpringBootWebApplication.java

+6-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package com.alipay.sofa.tracer.boot.base;
1818

1919
import org.springframework.boot.SpringApplication;
20+
import org.springframework.boot.autoconfigure.mongo.embedded.EmbeddedMongoAutoConfiguration;
2021
import org.springframework.cloud.client.loadbalancer.LoadBalanced;
2122
import org.springframework.context.annotation.Bean;
2223
import org.springframework.context.annotation.ImportResource;
@@ -28,7 +29,11 @@
2829
* @author yangguanchao
2930
* @since 2018/04/30
3031
*/
31-
@org.springframework.boot.autoconfigure.SpringBootApplication
32+
@org.springframework.boot.autoconfigure.SpringBootApplication(
33+
exclude = {
34+
EmbeddedMongoAutoConfiguration.class
35+
}
36+
)
3237
@ImportResource({ "classpath:hikariDataSource.xml" })
3338
public class SpringBootWebApplication {
3439

tracer-sofa-boot-starter/src/test/java/com/alipay/sofa/tracer/boot/config/ConfigurationTest.java

-5
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,12 @@
1919
import com.alipay.common.tracer.core.appender.file.TimedRollingFileAppender;
2020
import com.alipay.sofa.tracer.boot.base.AbstractTestBase;
2121
import com.alipay.sofa.tracer.boot.base.ConfigurationHolder;
22-
import com.alipay.sofa.tracer.boot.base.SpringBootWebApplication;
2322
import com.alipay.sofa.tracer.boot.properties.SofaTracerProperties;
2423
import org.apache.commons.io.FileUtils;
2524
import org.junit.Assert;
2625
import org.junit.BeforeClass;
2726
import org.junit.Test;
28-
import org.junit.runner.RunWith;
29-
import org.springframework.boot.test.context.SpringBootTest;
3027
import org.springframework.test.context.ActiveProfiles;
31-
import org.springframework.test.context.TestPropertySource;
32-
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
3328

3429
import java.io.File;
3530
import java.util.Map;

tracer-test/core-test/pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
<dependency>
2727
<groupId>org.mockito</groupId>
2828
<artifactId>mockito-core</artifactId>
29-
<version>2.3.0</version>
3029
<scope>test</scope>
3130
</dependency>
3231

0 commit comments

Comments
 (0)