Faraday's env#stream_reaponse? may be undefined in old Faradays #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

olleolleolle opened this issue Mar 25, 2025 · 1 comment

Contributor

olleolleolle commented Mar 25, 2025 •

edited

Loading

https://lostisland.github.io/faraday/#/adapters/custom/streaming This feature of Faraday was introduced at some point, but this gem does not pin to a any specific Faraday version.

Perhaps this adapter could sniff whether the streaming response methods were available, to avoid failure on old Faradays. Or some other solution. I'll link to someone's experience in a comment. Here: github-changelog-generator/github-changelog-generator#1056 (comment)

Member

ioquatix commented Mar 25, 2025

I'd be fine with feature sniffing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment