Skip to content

Commit 91b948b

Browse files
refactor: move the typed events to @socket.io/component-emitter
The typed events have been moved to [1] in order to remove the intermediary class and reduce the bundle size. Diff: socketio/emitter@2.0.0...3.0.0 [1]: https://github.com/socketio/emitter/
1 parent a9e5b85 commit 91b948b

File tree

7 files changed

+57
-413
lines changed

7 files changed

+57
-413
lines changed

lib/manager.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import Backoff from "backo2";
1111
import {
1212
DefaultEventsMap,
1313
EventsMap,
14-
StrictEventEmitter,
15-
} from "./typed-events.js";
14+
Emitter,
15+
} from "@socket.io/component-emitter";
1616
import debugModule from "debug"; // debug()
1717

1818
const debug = debugModule("socket.io-client:manager"); // debug()
@@ -100,7 +100,7 @@ interface ManagerReservedEvents {
100100
export class Manager<
101101
ListenEvents extends EventsMap = DefaultEventsMap,
102102
EmitEvents extends EventsMap = ListenEvents
103-
> extends StrictEventEmitter<{}, {}, ManagerReservedEvents> {
103+
> extends Emitter<{}, {}, ManagerReservedEvents> {
104104
/**
105105
* The Engine.IO client instance
106106
*
@@ -353,6 +353,7 @@ export class Manager<
353353
debug("connect attempt timed out after %d", timeout);
354354
openSubDestroy();
355355
socket.close();
356+
// @ts-ignore
356357
socket.emit("error", new Error("timeout"));
357358
}, timeout);
358359

lib/on.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
import type * as Emitter from "component-emitter";
2-
import { StrictEventEmitter } from "./typed-events.js";
1+
import { Emitter } from "@socket.io/component-emitter";
32

43
export function on(
5-
obj: Emitter | StrictEventEmitter<any, any>,
4+
obj: Emitter<any, any>,
65
ev: string,
76
fn: (err?: any) => any
87
): VoidFunction {

lib/socket.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import {
66
EventNames,
77
EventParams,
88
EventsMap,
9-
StrictEventEmitter,
10-
} from "./typed-events.js";
9+
Emitter,
10+
} from "@socket.io/component-emitter";
1111
import debugModule from "debug"; // debug()
1212

1313
const debug = debugModule("socket.io-client:socket"); // debug()
@@ -47,7 +47,7 @@ interface SocketReservedEvents {
4747
export class Socket<
4848
ListenEvents extends EventsMap = DefaultEventsMap,
4949
EmitEvents extends EventsMap = ListenEvents
50-
> extends StrictEventEmitter<ListenEvents, EmitEvents, SocketReservedEvents> {
50+
> extends Emitter<ListenEvents, EmitEvents, SocketReservedEvents> {
5151
public readonly io: Manager<ListenEvents, EmitEvents>;
5252

5353
public id: string;

lib/typed-events.ts

Lines changed: 0 additions & 210 deletions
This file was deleted.

0 commit comments

Comments
 (0)