Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internal components into their own namespace #185

Open
jbeemster opened this issue Dec 16, 2016 · 1 comment
Open

Move internal components into their own namespace #185

jbeemster opened this issue Dec 16, 2016 · 1 comment
Labels
category:breaking_change A breaking change will be introduced if this issue is completed.

Comments

@jbeemster
Copy link
Member

jbeemster commented Dec 16, 2016

It is meant to be exclusive - just for the core payload key-value pairs. The reason it gets confusing is that you can insert a TrackerPayload as the data component of a SelfDescribing json because it is really just a Map under the hood. We could probably clarify this by:

  1. Renaming it to something more appropriate like NonEmptyStringMap
  2. Removing the ability to pass this object directly into the SelfDescribingJson

Perhaps there is something around package visibility we should be toggling too...

cc/ @alexanderdean

@jbeemster jbeemster self-assigned this Dec 16, 2016
@mscwilson
Copy link
Contributor

This issue is broader than just TrackerPayload. I've changed the title to reflect that. We want to hide "private" parts of the code - in an internal namespace as suggested - to allow us greater flexibility in future for creating breaking changes. This change would also make the tracker easier to use with a better API.

@mscwilson mscwilson changed the title Discussion: hiding TrackerPayload from public view Move internal components into their own namespace Dec 6, 2021
@mscwilson mscwilson added this to the Version 1.0.0 milestone Dec 6, 2021
@mscwilson mscwilson added the category:breaking_change A breaking change will be introduced if this issue is completed. label Dec 6, 2021
@mscwilson mscwilson removed this from the Version 1.0.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:breaking_change A breaking change will be introduced if this issue is completed.
Projects
None yet
Development

No branches or pull requests

2 participants