Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to send each POST with a maximum byte size #170

Open
jbeemster opened this issue Sep 23, 2015 · 1 comment
Open

Add option to send each POST with a maximum byte size #170

jbeemster opened this issue Sep 23, 2015 · 1 comment
Labels
type:enhancement New features or improvements to existing features.

Comments

@jbeemster
Copy link
Member

This will build a POST up to the maximum byte size specified to ensure minimal amount of requests are sent.

This could work well with a combination of this ticket: snowplow/snowplow-ios-tracker#237

@jbeemster jbeemster added the type:enhancement New features or improvements to existing features. label Sep 23, 2015
@jbeemster jbeemster self-assigned this Sep 23, 2015
@jbeemster jbeemster added this to the Version 0.9.0 milestone Sep 23, 2015
@mscwilson
Copy link
Contributor

There's another old issue about payload size - #168 "Add batching based on payload size". Therefore I'm reading this issue as being about oversized payloads - giving users the ability to set a maximum byte size for a single POST request.

An oversize payload can arise from a single Event being large, normally due to a large number of attached context entities. Alternatively, calling Emitter.flushBuffer() could cause a large number of normal size events to be batched into a single payload.

The Android tracker has long had the ability to detect oversize payloads, although I'm not sure what it does differently except logging.

@mscwilson mscwilson removed this from the Version 0.12.0 milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New features or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

3 participants