-
Notifications
You must be signed in to change notification settings - Fork 4
Nicer code blocks #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Nicer code blocks #1510
Conversation
✅ Deploy Preview for snowplow-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
stanch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of glossed over the CSS changes, but the result looks great!
TBF the majority of the css diff is auto-linting that I was too lazy to figure out how to revert ¯_(ツ)_/¯ |
mscwilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this specific pair of themes (i can live with it), but the code block looks great. The language badge is a very good addition
@mscwilson open to other themes if you have suggestions! I just tried to use one of the existing built-in ones which were somewhat limited. |
|
@mscwilson small nits, but I don't love how (1) it's not consistent across light and dark (e.g. teal vs purple comments, black vs teal variable names) and (2) the teal-on-grey comments is a bit hard to read in the light mode. Let me know if you want me to take a stab at updating that. |
|
I've pushed my themes commit, feel free to do whatever with it! I asked Claude to update it based on your feedback btw, it's more standardised across light/dark now |



Introduces a more polished code block component. Also did some general css cleanup.
Changes
Code block improvements:
General cleanup:
Screenshots
Light them

e
Dark theme
