fix: proper use of relpath to define symlink

johanneskoester · johanneskoester · commit 2295f7fdcbeb · 2025-03-20T10:57:05.000+01:00
diff --git a/snakemake_storage_plugin_fs/__init__.py b/snakemake_storage_plugin_fs/__init__.py
@@ -204,7 +204,9 @@ def retrieve_object(self):
                 f"Creating symlink for on-demand retrieval of {self.query_path}."
             )
             os.symlink(
-                self.query_path,
+                # we have to use os.path.relpath here because Path.relative_to
+                # does not allow usage of paths that are in different directories.
+                os.path.relpath(self.query_path, self.local_path().parent),
                 self.local_path(),
                 target_is_directory=self.query_path.is_dir(),
             )

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,9 @@ def retrieve_object(self):`
`204`	`204`	`f"Creating symlink for on-demand retrieval of {self.query_path}."`
`205`	`205`	`)`
`206`	`206`	`os.symlink(`
`207`		`- self.query_path,`
	`207`	`+ # we have to use os.path.relpath here because Path.relative_to`
	`208`	`+ # does not allow usage of paths that are in different directories.`
	`209`	`+ os.path.relpath(self.query_path, self.local_path().parent),`
`208`	`210`	`self.local_path(),`
`209`	`211`	`target_is_directory=self.query_path.is_dir(),`
`210`	`212`	`)`