Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwa_indexpoint - add option to only return streams associated with the fundamental watershed in which the point occurs #86

Open
smnorris opened this issue Mar 31, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@smnorris
Copy link
Owner

smnorris commented Mar 31, 2022

This is unlikely to guarantee the function will only return streams that the point will flow to, but it should do so in the vast majority of cases.

@smnorris smnorris changed the title fwa_indexpoint - add option to only return stream associated with the fundamental watershed in which the point occurs fwa_indexpoint - add option to only return streams associated with the fundamental watershed in which the point occurs Mar 31, 2022
@smnorris
Copy link
Owner Author

smnorris commented Apr 21, 2022

While a 'within_same_watershed' option for the function would be great, it is not so simple in many locations. Consider adjacent to double line rivers: https://features.hillcrestgeo.ca/fwa/collections/whse_basemapping.fwa_watersheds_poly/items.html?watershed_feature_id=8492825

If asking for only features within the watershed in which the point is found, the Cowichan would not be included in the results, just the side channel and a disconnected pond.

It might be better to encourage the user to cast a fairly wide net, return a few indicators about how the stream and point relate and let the user choose the best match (mostly because input points tend to be inaccurate anyway, user should generally be checking against several matches to see if they are getting the best stream, usually by name).

Otherwise, maybe options like this:

fwa_indexpoint(x,y,srid,tolerance,num_features, match_type, include_disconnected, include_null_localcodes)

Where
match_type: nearest=return closest stream, flow=return only streams within same watershed or downstream
include_disconnected: true = include 999 streams
include_null_localcodes: true = include streams with null localcode

So, for general networking purposes, presuming input point is of good quality:

fwa_indexpoint(x, y, srid, 100, 1, flow, false, false) would give the best single result.

@smnorris
Copy link
Owner Author

Another issue with the function is that bc_ind is based only on intersection with watershed group polys. A better check is needed. A marine/terrestrial flag would be useful too.

@smnorris smnorris added this to the v1.0.0 milestone Jun 3, 2022
@smnorris smnorris added the enhancement New feature or request label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant