chore: test typefixes and update to integ test model

Author: kuhe

Makefile

@@ -18,6 +18,21 @@ generate-protocol-tests:
 test-protocols:
 	(cd ./private/smithy-rpcv2-cbor && npx vitest run --globals)
 
+test-unit:
+	yarn g:vitest run -c vitest.config.ts
+
+test-browser:
+	yarn g:vitest run -c vitest.config.browser.ts
+
+# typecheck for test code.
+test-types:
+	npx tsc -p tsconfig.test.json
+
+test-integration:
+	make test-browser
+	yarn g:vitest run -c vitest.config.integ.ts
+	make test-types
+
 turbo-clean:
 	@read -p "Are you sure you want to delete your local cache? [y/N]: " ans && [ $${ans:-N} = y ]
 	@echo "\nDeleted cache folders: \n--------"

package.json

@@ -7,8 +7,8 @@
   "scripts": {
     "clean": "turbo run clean --force --parallel",
     "build": "turbo run build",
-    "test": "turbo run test",
-    "test:integration": "yarn build-test-packages && turbo run test:integration",
+    "test": "make test-unit",
+    "test:integration": "yarn build-test-packages && make test-integration",
     "test:protocols": "make generate-protocol-tests test-protocols",
     "lint": "turbo run lint",
     "lint-fix": "turbo run lint -- --fix",

packages/config-resolver/src/regionConfig/isFipsRegion.spec.ts

@@ -12,6 +12,6 @@ describe(isFipsRegion.name, () => {
   });
 
   it.each([undefined, null])("returns false for %s", (input) => {
-    expect(isFipsRegion(input)).toEqual(false);
+    expect(isFipsRegion(input as any)).toEqual(false);
   });
 });

packages/config-resolver/src/regionConfig/resolveRegionConfig.spec.ts

@@ -54,8 +54,8 @@ describe("RegionConfig", () => {
   });
 
   describe("useFipsEndpoint", () => {
-    let mockRegionProvider;
-    let mockUseFipsEndpoint;
+    let mockRegionProvider: () => Promise<string>;
+    let mockUseFipsEndpoint: () => Promise<boolean>;
 
     beforeEach(() => {
       mockRegionProvider = vi.fn().mockResolvedValueOnce(Promise.resolve(mockRegion));

packages/config-resolver/src/regionInfo/getRegionInfo.spec.ts

@@ -56,9 +56,9 @@ describe(getRegionInfo.name, () => {
   const getMockResolvedRegion = (regionCase: RegionCase): string =>
     regionCase !== RegionCase.ENDPOINT ? mockRegion : mockEndpointRegion;
 
-  const getMockResolvedPartitionOptions = (partitionHash) => ({ partitionHash });
+  const getMockResolvedPartitionOptions = (partitionHash: PartitionHash) => ({ partitionHash });
 
-  const getMockRegionInfoOptions = (regionHash, getResolvedPartitionOptions) => ({
+  const getMockRegionInfoOptions = (regionHash: RegionHash, getResolvedPartitionOptions: any) => ({
     ...getResolvedPartitionOptions,
     signingService: mockSigningService,
     regionHash,

packages/config-resolver/src/regionInfo/getResolvedPartition.spec.ts

@@ -32,6 +32,6 @@ describe(getResolvedPartition.name, () => {
   });
 
   it("returns aws if partitionHash is empty", () => {
-    expect(getResolvedPartition(mockRegion, { partitionHash: undefined })).toBe("aws");
+    expect(getResolvedPartition(mockRegion, { partitionHash: undefined as any })).toBe("aws");
   });
 });

packages/core/src/submodules/cbor/cbor.spec.ts

@@ -1,4 +1,5 @@
 import * as fs from "fs";
+// @ts-ignore
 import JSONbig from "json-bigint";
 import * as path from "path";
 import { describe, expect, test as it } from "vitest";
@@ -290,7 +291,7 @@ describe("cbor", () => {
       return scalar * sum * exponentScalar;
     }
 
-    function translateTestData(data: any) {
+    function translateTestData(data: any): any {
       const [type, value] = Object.entries(data)[0] as [string, any];
       switch (type) {
         case "null":

packages/core/src/submodules/schema/middleware/schemaDeserializationMiddleware.spec.ts

@@ -85,7 +85,7 @@ describe(schemaDeserializationMiddleware.name, () => {
     expect(mockNext).toHaveBeenCalledWith(mockArgs);
     expect(mockDeserializer).toHaveBeenCalledTimes(1);
     expect(mockDeserializer).toHaveBeenCalledWith(
-      undefined as SchemaRef,
+      undefined as any as SchemaRef,
       {
         ...mockOptions,
         __smithy_context: {},

packages/core/src/submodules/schema/middleware/schemaSerializationMiddleware.spec.ts

@@ -59,7 +59,7 @@ describe(schemaSerializationMiddleware.name, () => {
     await expect(schemaSerializationMiddleware(mockOptions)(mockNext, {})(mockArgs)).resolves.toStrictEqual(mockReturn);
 
     expect(mockSerializer).toHaveBeenCalledTimes(1);
-    expect(mockSerializer).toHaveBeenCalledWith(undefined as SchemaRef, mockArgs.input, {
+    expect(mockSerializer).toHaveBeenCalledWith(undefined as unknown as SchemaRef, mockArgs.input, {
       ...mockOptions,
       __smithy_context: {},
     });

packages/credential-provider-imds/src/remoteProvider/httpRequest.spec.ts

@@ -20,7 +20,6 @@ import EventEmitter from "events";
 import { request } from "http";
 
 describe("httpRequest", () => {
-  let port: number;
   const hostname = "localhost";
   const path = "/";
 
@@ -53,7 +52,7 @@ describe("httpRequest", () => {
 
       mockResponse({ expectedResponse });
 
-      const response = await httpRequest({ hostname, path, port });
+      const response = await httpRequest({ hostname, path });
       expect(response.toString()).toStrictEqual(expectedResponse);
     });
 
@@ -62,7 +61,7 @@ describe("httpRequest", () => {
       const expectedResponse = "expectedResponse";
       mockResponse({ expectedResponse });
 
-      const response = await httpRequest({ hostname, path, port, method });
+      const response = await httpRequest({ hostname, path, method });
       expect(response.toString()).toStrictEqual(expectedResponse);
     });
 
@@ -71,7 +70,7 @@ describe("httpRequest", () => {
       const encapsulatedIPv6Hostname = "[::1]";
       mockResponse({ expectedResponse });
 
-      const response = await httpRequest({ hostname: encapsulatedIPv6Hostname, path, port });
+      const response = await httpRequest({ hostname: encapsulatedIPv6Hostname, path });
       expect(response.toString()).toStrictEqual(expectedResponse);
     });
   });
@@ -84,7 +83,7 @@ describe("httpRequest", () => {
           expectedResponse: "continue",
         });
 
-        await expect(httpRequest({ hostname, path, port })).rejects.toStrictEqual(
+        await expect(httpRequest({ hostname, path })).rejects.toStrictEqual(
           Object.assign(new ProviderError("Error response received from instance metadata service"), { statusCode })
         );
       });
@@ -102,7 +101,7 @@ describe("httpRequest", () => {
         return request;
       }) as any);
 
-      await expect(httpRequest({ hostname, path, port })).rejects.toStrictEqual(
+      await expect(httpRequest({ hostname, path })).rejects.toStrictEqual(
         new ProviderError("Unable to connect to instance metadata service")
       );
     });
@@ -131,7 +130,7 @@ describe("httpRequest", () => {
       return request;
     }) as any);
 
-    await expect(httpRequest({ hostname, path, port, timeout })).rejects.toStrictEqual(
+    await expect(httpRequest({ hostname, path, timeout })).rejects.toStrictEqual(
       new ProviderError("TimeoutError from instance metadata service")
     );
   });