Skip to content

The new aws-lc-sys-0.27.1 dependency started requiring cmake to build #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Veetaha opened this issue Mar 28, 2025 · 5 comments
Closed

The new aws-lc-sys-0.27.1 dependency started requiring cmake to build #4073

Veetaha opened this issue Mar 28, 2025 · 5 comments

Comments

@Veetaha
Copy link

Veetaha commented Mar 28, 2025

I upgraded AWS SDK in our repo, but when I submitted my PR to CI our windows build failed with this:

 --- stderr
  Missing dependency: cmake

  thread 'main' panicked at C:\Users\Administrator\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\aws-lc-sys-0.27.1\builder\main.rs:382:40:
  called `Result::unwrap()` on an `Err` value: "Required build dependency is missing. Halting build."

Is there any way the cmake requirement can be removed? The builds worked just fine without it before.

Related PR: #4040

@aajtodd
Copy link
Contributor

aajtodd commented Mar 28, 2025

What target are you building for? On what platform are you building on?

The build requirements for aws-lc-rs are listed here. For common linux/macos targets the only thing required should be a working C compiler. For other targets cmake and/or other dependencies are required.

@Veetaha
Copy link
Author

Veetaha commented Mar 28, 2025

What target are you building for? On what platform are you building on?

Oh sorry, I totally missed to specify that. It's a Windows build that uses our custom Vagrant image. We could add CMake to that image, but I was thinking if that could be avoided at all;

More specifically it's windows2019-amd64

@aajtodd
Copy link
Contributor

aajtodd commented Mar 28, 2025

cmake is a required dependency to build aws-lc-rs on windows unfortunately. See the windows build deps. We understand this was a breaking build time change for some users, this was an intentional choice though. You can find more information on the changes in this discussion.

@Veetaha
Copy link
Author

Veetaha commented Mar 28, 2025

I see, that's unfortunate, but if it's intentional I'm closing the issue

@Veetaha Veetaha closed this as completed Mar 28, 2025
@Veetaha
Copy link
Author

Veetaha commented Apr 2, 2025

Sorry, I couldn't keep myself from posting this 😳
https://www.reddit.com/r/rustjerk/comments/1jpt6j7/but_its_good_intentions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants