Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust toolchain caching in CI could use dynamic CIBW_ENVIRONMENT definitions to set paths #46

Open
smheidrich opened this issue Oct 31, 2022 · 0 comments

Comments

@smheidrich
Copy link
Owner

For Linux, there is currently an overcomplicated mechanism involving moving container-specific cache directories to and from the global cache dir into static paths that have previously been set in PATH and CARGO_HOME/RUSTUP_HOME. I did it this way because I thought I'd only have access to the name of the current architecture inside the before_all, before_build and test/repair commands.

But actually, CIBW_ENVIRONMENT is evaluated inside each container, so I already have access to the name of the architecture there, e.g. via $(uname -m). Hence, this can be simplified to not move anything around and just set architecture-containing paths from the get go.

Cf. pypa/cibuildwheel#1329 (comment)

@smheidrich smheidrich changed the title Rust toolchain caching in CI could be simplified Rust toolchain caching in CI could use dynamic CIBW_ENVIRONMENT to set paths Oct 31, 2022
@smheidrich smheidrich changed the title Rust toolchain caching in CI could use dynamic CIBW_ENVIRONMENT to set paths Rust toolchain caching in CI could use dynamic CIBW_ENVIRONMENT definitions to set paths Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant