-Code review

Author: smhdk

.idea/misc.xml

@@ -5,6 +5,7 @@
 import android.os.Bundle;
 import android.support.annotation.Nullable;
 import android.view.View;
+import android.widget.TextView;
 import android.widget.Toast;
 
 import com.hololo.tutorial.library.PermissionStep;
@@ -13,8 +14,6 @@
 
 public class MainActivity extends TutorialActivity {
 
-    private View currentFragmentView;
-    private String currentFragmentTag;
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
@@ -37,15 +36,18 @@ protected void onCreate(Bundle savedInstanceState) {
                 .build());
 
         addFragment(new Step.Builder()
+                .setTitle(getString(R.string.choose_the_song))
+                .setContent(getString(R.string.swap_to_the_tab))
+                .setBackgroundColor(Color.parseColor("#00D4BA"))
+                .setDrawable(R.drawable.ss_2)
+                .setSummary(getString(R.string.continue_and_update)).build());
 
-                .build());
 
         addFragment(new Step.Builder()
-                .setTitle(getString(R.string.edit_data))
-                .setContent(getString(R.string.update_easily))
+                .setTitle("Custom Layout Sample")
                 .setBackgroundColor(Color.parseColor("#1098FE"))
-                .setDrawable(R.drawable.ss_3)
-                .setSummary(getString(R.string.continue_and_result))
+                .setView(R.layout.layout_sample)
+                .setTag("sampleTag")
                 .build());
 
         addFragment(new Step.Builder()
@@ -69,15 +71,17 @@ public void cancelTutorial() {
     }
 
     @Override
-    public void currentFragmentPosition(int position) {
-        Toast.makeText(this, "Position : " + position, Toast.LENGTH_SHORT).show();
-    }
-
-    @Override
-    public void currentFragmentView(@Nullable View view, @Nullable String tag) {
-        currentFragmentView = view;
-        currentFragmentTag = tag;
+    public void currentFragment(@Nullable final View view, Integer position) {
+        if (view != null && position == 3) {
+            TextView contentTextview = view.findViewById(R.id.content);
+            contentTextview.setText("Click This");
+
+            contentTextview.setOnClickListener(new View.OnClickListener() {
+                @Override
+                public void onClick(View v) {
+                    Toast.makeText(view.getContext(), "You can get current view and implementation it", Toast.LENGTH_LONG).show();
+                }
+            });
+        }
     }
-
-
 }

.idea/modules.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent">
+
+    <TextView
+        android:id="@+id/title"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_above="@+id/content"
+        android:layout_centerInParent="true"
+        android:layout_margin="16dp"
+        android:padding="16dp"
+        android:textAlignment="center"
+        android:textSize="18sp" />
+
+    <TextView
+        android:id="@+id/content"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_centerInParent="true"
+        android:layout_margin="16dp"
+        android:padding="16dp"
+        android:textAlignment="center" />
+
+</RelativeLayout>

app/src/main/java/com/hololo/tutorial/sample/MainActivity.java

@@ -4,7 +4,5 @@
 import android.view.View;
 
 public interface CurrentFragmentListener {
-    void currentFragmentPosition(int position);
-
-    void currentFragmentView(@Nullable View view, @Nullable String tag);
+    void currentFragment(@Nullable View view, @Nullable Integer position);
 }

app/src/main/res/layout/layout_sample.xml

@@ -10,19 +10,17 @@
 
 public class StepFragment extends StepView {
 
-    private static CurrentFragmentListener currentFragmentListener;
     private TextView title;
     private TextView content;
     private TextView summary;
     private ImageView imageView;
     private View layout;
 
-    static StepFragment createFragment(Step step, CurrentFragmentListener listener, int pos) {
+    static StepFragment createFragment(Step step, int pos) {
         StepFragment fragment = new StepFragment();
         Bundle bundle = new Bundle();
         bundle.putParcelable("step", step);
         fragment.setArguments(bundle);
-        currentFragmentListener = listener;
         return fragment;
     }
 
@@ -39,7 +37,7 @@ public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container,
         int layout = step.getViewType() > 0 ? step.getViewType() : R.layout.fragment_step;
 
         View view = inflater.inflate(layout, container, false);
-        currentFragmentListener.currentFragmentView(view, step.getTag());
+        view.setTag(step.getTag());
         initViews(view);
         initData();
 

library/src/main/java/com/hololo/tutorial/library/CurrentFragmentListener.java

@@ -8,12 +8,10 @@
 
 public class StepPagerAdapter extends FragmentPagerAdapter {
     private List<Step> stepList;
-    private CurrentFragmentListener currentFragmentListener;
 
-    public StepPagerAdapter(FragmentManager fm, List<Step> stepList, CurrentFragmentListener listener) {
+    public StepPagerAdapter(FragmentManager fm, List<Step> stepList) {
         super(fm);
         this.stepList = stepList;
-        this.currentFragmentListener = listener;
     }
 
 
@@ -25,7 +23,6 @@ public int getCount() {
     @Override
     public Fragment getItem(int position) {
         Step step = stepList.get(position);
-
-        return StepFragment.createFragment(step, currentFragmentListener, position);
+        return StepFragment.createFragment(step, position);
     }
 }

library/src/main/java/com/hololo/tutorial/library/StepFragment.java

@@ -7,6 +7,7 @@
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.support.annotation.RequiresApi;
+import android.support.v4.app.Fragment;
 import android.support.v4.view.ViewPager;
 import android.support.v7.app.AppCompatActivity;
 import android.view.MotionEvent;
@@ -22,7 +23,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
-public abstract class TutorialActivity extends AppCompatActivity implements View.OnClickListener, CurrentFragmentListener {
+public abstract class TutorialActivity extends AppCompatActivity implements View.OnClickListener {
 
     private List<Step> steps;
     private StepPagerAdapter adapter;
@@ -32,8 +33,6 @@ public abstract class TutorialActivity extends AppCompatActivity implements View
     private LinearLayout indicatorLayout;
     private FrameLayout containerLayout;
     private RelativeLayout buttonContainer;
-    private CurrentFragmentListener currentFragmentListener;
-
     private int currentItem;
 
     private String prevText, nextText, finishText, cancelText, givePermissionText;
@@ -44,7 +43,6 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
         setTheme(R.style.TutorialStyle);
         super.onCreate(savedInstanceState);
         setContentView(R.layout.activity_tutorial);
-        currentFragmentListener = this;
         init();
     }
 
@@ -64,7 +62,7 @@ private void initTexts() {
     }
 
     private void initAdapter() {
-        adapter = new StepPagerAdapter(getSupportFragmentManager(), steps, this);
+        adapter = new StepPagerAdapter(getSupportFragmentManager(), steps);
         pager.setAdapter(adapter);
         pager.addOnPageChangeListener(new ViewPager.OnPageChangeListener() {
             @Override
@@ -75,7 +73,7 @@ public void onPageScrolled(int position, float positionOffset, int positionOffse
             @Override
             public void onPageSelected(int position) {
                 currentItem = position;
-                currentFragmentListener.currentFragmentPosition(position);
+                currentFragment(((Fragment) adapter.instantiateItem(pager, position)).getView(), position);
                 controlPosition(position);
             }
 
@@ -251,6 +249,10 @@ public void finishTutorial() {
     public void cancelTutorial() {
     }
 
+    public void currentFragment(@Nullable View view, Integer position) {
+
+    }
+
     public void setPrevText(String text) {
         prevText = text;
     }