- refactor graphql_can_load_plugin

- remove files from autoloader that are required before autoloading is loaded
- define WPGRAPHQL_AUTOLOAD in constants.php
- update graphql_activation and graphql_deactivation

Author: jasonbahl

activation.php

@@ -5,8 +5,13 @@
  * @return void
  */
 function graphql_activation_callback() {
+
 	do_action( 'graphql_activate' );
 
+	if ( ! defined( 'WPGRAPHQL_VERSION' ) ) {
+		return;
+	}
+
 	// store the current version of WPGraphQL
 	update_option( 'wp_graphql_version', WPGRAPHQL_VERSION );
 }

composer.json

@@ -60,12 +60,7 @@
 		}
 	},
 	"autoload": {
-		"files": [
-			"access-functions.php",
-			"constants.php",
-			"activation.php",
-			"deactivation.php"
-		],
+		"files": [],
 		"psr-4": {
 			"WPGraphQL\\": "src/"
 		}

constants.php

@@ -9,6 +9,13 @@
  */
 function graphql_setup_constants() {
 
+	// Whether to autoload the files or not.
+	// This must be defined here and not within the WPGraphQL.php because this constant
+	// determines whether to autoload classes or not
+	if ( ! defined( 'WPGRAPHQL_AUTOLOAD' ) ) {
+		define( 'WPGRAPHQL_AUTOLOAD', true );
+	}
+
 	// Plugin version.
 	if ( ! defined( 'WPGRAPHQL_VERSION' ) ) {
 		define( 'WPGRAPHQL_VERSION', '1.16.0' );

deactivation.php

@@ -8,6 +8,10 @@
  */
 function graphql_deactivation_callback() {
 
+	if ( ! graphql_can_load_plugin() ) {
+		return;
+	}
+
 	// Fire an action when WPGraphQL is de-activating
 	do_action( 'graphql_deactivate' );
 
@@ -22,6 +26,10 @@ function graphql_deactivation_callback() {
  */
 function delete_graphql_data() {
 
+	if ( ! class_exists( 'WPGraphQL' ) ) {
+		return;
+	}
+
 	// Check if the plugin is set to delete data or not
 	$delete_data = get_graphql_setting( 'delete_data_on_deactivate' );
 

wp-graphql.php

@@ -32,27 +32,50 @@
 	require_once __DIR__ . '/c3.php';
 }
 
-// Whether to autoload the files or not.
-// This must be defined here and not within the WPGraphQL.php because this constant
-// determines whether to autoload classes or not
-if ( ! defined( 'WPGRAPHQL_AUTOLOAD' ) ) {
-	define( 'WPGRAPHQL_AUTOLOAD', true );
+// Bootstrap files that are neded before autoloader is bootstrapped
+if ( file_exists( __DIR__ . '/access-functions.php' ) ) {
+	require_once __DIR__ . '/access-functions.php';
+}
+if ( file_exists( __DIR__ . '/constants.php' ) ) {
+	require_once __DIR__ . '/constants.php';
+}
+if ( file_exists( __DIR__ . '/activation.php' ) ) {
+	require_once __DIR__ . '/activation.php';
+}
+if ( file_exists( __DIR__ . '/deactivation.php' ) ) {
+	require_once __DIR__ . '/deactivation.php';
 }
 
 // Run this function when WPGraphQL is de-activated
 register_deactivation_hook( __FILE__, 'graphql_deactivation_callback' );
 register_activation_hook( __FILE__, 'graphql_activation_callback' );
 
-// Bootstrap the plugin
-if ( ! class_exists( 'WPGraphQL' ) ) {
-	require_once __DIR__ . '/src/WPGraphQL.php';
-}
-
 /**
+ * test env:
+ *  - WPGRAPHQL_AUTOLOAD: false
+ *  - autoload installed and manually added in test env
+ *
+ * Bedrock
+ *  - WPGRAPHQL_AUTOLOAD: not defined
+ *  - composer deps installed outside of the plugin
+ *
+ * Normal (.org repo install)
+ * - WPGRAPHQL_AUTOLOAD: not defined
+ * - composer deps installed INSIDE the plugin
+ *
+ *
  * @return bool
  */
 function graphql_can_load_plugin(): bool {
 
+
+	$can_load      = false;
+	$autoload_file = plugin_dir_path( __FILE__ ) . 'vendor/autoload.php';
+
+	if ( class_exists( 'WPGraphQL' ) ) {
+		return true;
+	}
+
 	/**
 	 * WPGRAPHQL_AUTOLOAD can be set to "false" to prevent the autoloader from running.
 	 * In most cases, this is not something that should be disabled, but some environments
@@ -68,38 +91,27 @@ function graphql_can_load_plugin(): bool {
 		// IF WPGRAPHQL_AUTOLOAD is defined as false,
 		// but the WPGraphQL Class exists, we can assume the dependencies
 		// are loaded from the parent project.
-		if ( class_exists( '\WPGraphQL' ) ) {
-			return true;
-		}
+		return true;
+
 	}
 
-	// If the autoload file exists, load it
-	if ( file_exists( plugin_dir_path( __FILE__ ) . 'vendor/autoload.php' ) ) {
+	if ( ( ! defined( 'WPGRAPHQL_AUTOLOAD' ) || true === WPGRAPHQL_AUTOLOAD ) && file_exists( $autoload_file ) ) {
 		// Autoload Required Classes.
-		require_once plugin_dir_path( __FILE__ ) . 'vendor/autoload.php';
+		require_once( $autoload_file );
+		// Bootstrap the plugin
+		if ( ! class_exists( 'WPGraphQL' ) ) {
+			require_once __DIR__ . '/src/WPGraphQL.php';
+		}
 		return true;
-		// If the autoload file doesn't exist
-		// manually load the individual files defined
-		// in the composer.json
 	}
 
-	add_action(
-		'admin_notices',
-		static function () {
-			if ( ! current_user_can( 'manage_options' ) ) {
-				return;
-			}
-
-			printf(
-				'<div class="notice notice-error">' .
-				'<p>%s</p>' .
-				'</div>',
-				esc_html__( 'WPGraphQL appears to have been installed without it\'s dependencies. It will not work properly until dependencies are installed. This likely means you have cloned WPGraphQL from Github and need to run the command `composer install`.', 'wp-graphql' )
-			);
-		}
-	);
+	// Bootstrap the plugin
+	if ( ! class_exists( '\WPGraphQL' ) ) {
+		return false;
+	}
+
+	return true;
 
-	return false;
 }
 
 if ( ! function_exists( 'graphql_init' ) ) {
@@ -112,6 +124,8 @@ function graphql_init() {
 
 		// if the plugin can't be loaded, bail
 		if ( false === graphql_can_load_plugin() ) {
+			add_action( 'network_admin_notices', 'graphql_cannot_load_admin_notice_callback' );
+			add_action( 'admin_notices', 'graphql_cannot_load_admin_notice_callback' );
 			return null;
 		}
 
@@ -123,6 +137,19 @@ function graphql_init() {
 }
 graphql_init();
 
+function graphql_cannot_load_admin_notice_callback() {
+	if ( ! current_user_can( 'manage_options' ) ) {
+		return;
+	}
+
+	printf(
+		'<div class="notice notice-error">' .
+		'<p>%s</p>' .
+		'</div>',
+		esc_html__( 'WPGraphQL appears to have been installed without it\'s dependencies. It will not work properly until dependencies are installed. This likely means you have cloned WPGraphQL from Github and need to run the command `composer install`.', 'wp-graphql' )
+	);
+}
+
 if ( defined( 'WP_CLI' ) && WP_CLI ) {
 	require_once plugin_dir_path( __FILE__ ) . 'cli/wp-cli.php';
 }