Little Error in Lesson 10? #648
-
|
Hello, |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 8 replies
-
|
Hello @guiri93 nice punctuation, what do you think about this @PatrickAlphaC ? |
Beta Was this translation helpful? Give feedback.
-
|
You will have some leftover, our repay function only repays what we have, and you'll have accrued some interest so you'll still have some to pay back |
Beta Was this translation helpful? Give feedback.
-
|
That's interesting, @guiri93 does this makes sense to you? |
Beta Was this translation helpful? Give feedback.
-
|
Yes, I see the point. However when I run repay with my parameters, in the end the function get_borrowable_data(lending_pool, account) returns something like "You have 1.78...E-9 worth of ETH borrowed." This small number is explainable by the interests we paid. get_borrowable_data(lending_pool, account) gives something like "You have 0.078375000000000003 worth of ETH borrowed." After repaying the function gives "You have 0.078342892303195526 worth of ETH borrowed." So we actually only repaid 0.00003... worth of ETH. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I am having the same problem. I think @guiri93 is right about having to repay |
Beta Was this translation helpful? Give feedback.
-
|
Could you show the outputs of your scripts to get to what you're seeing? |
Beta Was this translation helpful? Give feedback.
-
|
Sorry it took me so long. This is the script from the GitHub repo: (python397) user@Air-de-Jan AAVE_Brownie % brownie run scripts/solution_script.py AaveBrownieProject is the active project. Launching 'ganache-cli --accounts 10 --hardfork istanbul --fork https://mainnet.infura.io/v3/ddfc1c9cbbd943369147bfe060fd5c0d --gasLimit 12000000 --mnemonic brownie --port 8545 --chainId 1'... Running 'scripts/solution_script.py::main'... IWeth.deposit confirmed Block: 14023945 Gas used: 43738 (0.36%) Received 0.1 Weth IERC20.approve confirmed Block: 14023946 Gas used: 43952 (0.37%) Approved! ILendingPool.deposit confirmed Block: 14023947 Gas used: 250114 (2.08%) Deposited! ILendingPool.borrow confirmed Block: 14023948 Gas used: 369970 (3.08%) We borrowed some DAI! IERC20.approve confirmed Block: 14023949 Gas used: 44106 (0.37%) Approved! ILendingPool.repay confirmed Block: 14023950 Gas used: 261245 (2.18%) Repaid! And this is the output when I change the parameters of the repay function: (python397)user@Air-de-Jan AAVE_Brownie % brownie run scripts/aave_borrow.py AaveBrownieProject is the active project. Launching 'ganache-cli --accounts 10 --hardfork istanbul --fork https://mainnet.infura.io/v3/ddfc1c9cbbd943369147bfe060fd5c0d --gasLimit 12000000 --mnemonic brownie --port 8545 --chainId 1'... Running 'scripts/aave_borrow.py::main'... IWeth.deposit confirmed Block: 14023962 Gas used: 43738 (0.36%) Received 0.1 Weth IERC20.approve confirmed Block: 14023963 Gas used: 43952 (0.37%) approved ILendingPool.deposit confirmed Block: 14023964 Gas used: 250114 (2.08%) deposeted ILendingPool.borrow confirmed Block: 14023965 Gas used: 369982 (3.08%) borrowed_some_dai IERC20.approve confirmed Block: 14023966 Gas used: 44142 (0.37%) approved ILendingPool.repay confirmed Block: 14023967 Gas used: 261281 (2.18%) repayed |
Beta Was this translation helpful? Give feedback.
-
|
I just tried this... it looks like you're right. I made a big oopsie... Thanks for catching!!! I'll make a PR to fix... |
Beta Was this translation helpful? Give feedback.
-
|
I have updated here: PatrickAlphaC/aave_brownie_py_freecode@ff488ac And am making a PR to the issues doc for this. Looks like some others tried to tell me and I lazily didn't look deep enough. Thank you both so much!! Sorry for the confusion :( Appreciate it! |
Beta Was this translation helpful? Give feedback.
-
|
Updated in this repo here: d64d413 Thanks again!! |
Beta Was this translation helpful? Give feedback.
Hi,
I am having the same problem. I think @guiri93 is right about having to repay
amount_to_borrow. If I'm not mistaken right now we are repaying 0.1 (AMOUNT) DAI but we borrowed 95% of 0.1 ETH worth in DAI