Lesson 7 problems with endLottery

[cromewar]

Hello I'm trying to execute endLottery() but my transaction gets reverted every time, my code:

    function endLottery() public onlyOwner {
        lottery_state = LOTTERY_STATE.CALCULATING_WINNER;
        bytes32 requestId = requestRandomness(keyhash, fee);
    }

    function fulfillRandomness(bytes32 _requestId, uint256 _randomness)
        internal
        override
    {
        require(
            // require an specific state of the lottery
            lottery_state == LOTTERY_STATE.CALCULATING_WINNER,
            "you aren't there yet."
        );
        // Make sure the node have returned a random value
        require(_randomness > 0, "random-not-found");
        // Select the winner based on the pull of players using de modulo.
        uint256 indexOfWinner = _randomness % players.length;
        // to know who won last.
        recentWinner = players[indexOfWinner];
        // transfer all funds to the winner
        recentWinner.transfer(address(this).balance);
        //Reset the lottery players
        players = new address payable[](0);
        // change de lottery state
        lottery_state = LOTTERY_STATE.CLOSED;
        // to verify the rando number
        randomness = _randomness;
    }

and my deploy script:

def end_lottery():
    account = get_account()
    lottery = Lottery[-1]
    # fund de contract and  end the lottery
    tx = fund_with_link(lottery.address)
    tx.wait(1)
    ending_transaction = lottery.endLottery({"from": account})
    ending_transaction.wait(2)
    time.sleep(60)
    print(f"{lottery.recentWinner()} is the winner!")
    print("Lottery ended successfully")

Here is the error I got

Any help is appreciated.

EDIT 1

When writing a unit test as course mentions I have the same error:

[cromewar]

I solved, however I have another question

The problem was I was given wrong positional arguments to the constructor I had this:

def deploy_lottery():
    # id="crome-account"
    account = get_account()
    lottery = Lottery.deploy(
        get_contract("eth_usd_price_feed").address,
        get_contract("link_token").address,
        get_contract("vrf_coordinator").address,
        config["networks"][network.show_active()]["fee"],
        config["networks"][network.show_active()]["keyhash"],
        {"from": account},
        publish_source=config["networks"][network.show_active()].get("verify", False),
    )
    print("Deployed Lottery!")
    return lottery

Instead of:

def deploy_lottery():
    # id="crome-account"
    account = get_account()
    lottery = Lottery.deploy(
        get_contract("eth_usd_price_feed").address,
        get_contract("vrf_coordinator").address,
        get_contract("link_token").address,
        config["networks"][network.show_active()]["fee"],
        config["networks"][network.show_active()]["keyhash"],
        {"from": account},
        publish_source=config["networks"][network.show_active()].get("verify", False),
    )
    print("Deployed Lottery!")
    return lottery

vrf_coordinator and link_token were misplaced, so I wonder is there any way to change the constructor to receive kword arguments instead of positional arguments? This kind of error gives real headaches because you don't have even a hint about whats wrong.

Any advice is welcome, Thanks :D

[PatrickAlphaC]

hmm... This might be a great enhancement for brownie!