minor fixes

Author: 0xsuryansh

chains/evm/.gas-snapshot

@@ -259,13 +259,11 @@ LockReleaseTokenPool_releaseOrMint:test_releaseOrMintV2() (gas: 246087)
 LockReleaseTokenPool_setRebalancer:test_SetRebalancer() (gas: 21811)
 LockReleaseTokenPool_supportsInterface:test_SupportsInterface() (gas: 10100)
 LockReleaseTokenPool_transferLiquidity:test_transferLiquidity() (gas: 97332)
-LombardTokenPool_constructor:test_constructor_SetsVerifierAndAllowance() (gas: 4034288)
-LombardTokenPool_constructor:test_constructor_ZeroVerifierReverts() (gas: 92403)
+LombardTokenPool_constructor:test_constructor() (gas: 4034394)
 LombardTokenPool_getTokenDecimals:test_getTokenDecimals_FallsBackOnRevert() (gas: 12048)
 LombardTokenPool_getTokenDecimals:test_getTokenDecimals_UsesTokenDecimals() (gas: 14363)
-LombardTokenPool_lockOrBurn:test_lockOrBurn_ForwardsToVerifier() (gas: 102637)
-LombardTokenPool_lockOrBurn:test_setVerifierRevertsOnZero() (gas: 11379)
-LombardTokenPool_lockOrBurn:test_setVerifierUpdatesAllowance() (gas: 61609)
+LombardTokenPool_lockOrBurn:test_lockOrBurn_ForwardsToVerifier() (gas: 102615)
+LombardTokenPool_setVerifier:test_setVerifier() (gas: 61477)
 MessageV1Codec__decodeMessageV1:test__decodeMessageV1_EmptyFields() (gas: 46889)
 MessageV1Codec__decodeMessageV1:test__decodeMessageV1_MaxLengthFields() (gas: 436236)
 MessageV1Codec__decodeMessageV1:test__decodeMessageV1_WithData() (gas: 57857)

chains/evm/contracts/pools/Lombard/LombardTokenPool.sol

@@ -14,7 +14,7 @@ import {SafeERC20} from "@openzeppelin/[email protected]/token/ERC20/utils/SafeERC
 /// For v2 flows, token movement (burn/mint or bridging) is handled by the Lombard verifier,
 /// the pool performs validation, rate limiting, accounting and event emission.
 /// IPoolV2.lockOrBurn forwards tokens to the verifier with _lockOrBurn.
-/// IPoolV2.releaseOrMint does not move tokens; it validates, consumes rate limits, and emits the event while the verifier delivers funds.
+/// IPoolV2.releaseOrMint does not move tokens, _releaseOrMint is a no-op.
 /// TODO: Add explicit V1 support/backwards compatibility.
 contract LombardTokenPool is TokenPool, ITypeAndVersion {
   using SafeERC20 for IERC20;

chains/evm/contracts/test/pools/LombardTokenPool/LombardTokenPool._getTokenDecimals.t.sol

@@ -4,6 +4,7 @@ pragma solidity ^0.8.24;
 import {BaseTest} from "../../BaseTest.t.sol";
 import {LombardTokenPoolHelper} from "../../helpers/LombardTokenPoolHelper.sol";
 import {BurnMintERC20} from "@chainlink/contracts/src/v0.8/shared/token/ERC20/BurnMintERC20.sol";
+
 import {IERC20Metadata} from "@openzeppelin/[email protected]/token/ERC20/extensions/IERC20Metadata.sol";
 
 contract LombardTokenPool_getTokenDecimals is BaseTest {

chains/evm/contracts/test/pools/LombardTokenPool/LombardTokenPool._lockOrBurn.t.sol

@@ -2,7 +2,6 @@
 pragma solidity ^0.8.24;
 
 import {Pool} from "../../../libraries/Pool.sol";
-import {LombardTokenPool} from "../../../pools/Lombard/LombardTokenPool.sol";
 import {LombardTokenPoolSetup} from "./LombardTokenPoolSetup.t.sol";
 
 contract LombardTokenPool_lockOrBurn is LombardTokenPoolSetup {
@@ -30,21 +29,4 @@ contract LombardTokenPool_lockOrBurn is LombardTokenPoolSetup {
     assertEq(s_token.balanceOf(VERIFIER), amount);
     assertEq(s_token.balanceOf(address(s_pool)), 0);
   }
-
-  function test_setVerifierUpdatesAllowance() public {
-    address newVerifier = makeAddr("newVerifier");
-
-    vm.prank(OWNER);
-    s_pool.setVerifier(newVerifier);
-
-    assertEq(s_pool.s_verifier(), newVerifier);
-    assertEq(s_token.allowance(address(s_pool), newVerifier), type(uint256).max);
-    assertEq(s_token.allowance(address(s_pool), VERIFIER), 0);
-  }
-
-  function test_setVerifierRevertsOnZero() public {
-    vm.prank(OWNER);
-    vm.expectRevert(LombardTokenPool.ZeroVerifierNotAllowed.selector);
-    s_pool.setVerifier(address(0));
-  }
 }

chains/evm/contracts/test/pools/LombardTokenPool/LombardTokenPool.constructor.t.sol

@@ -15,16 +15,11 @@ contract LombardTokenPool_constructor is Test {
     s_token = new BurnMintERC20("Lombard", "LBD", 18, 0, 0);
   }
 
-  function test_constructor_SetsVerifierAndAllowance() public {
+  function test_constructor() public {
     LombardTokenPool pool = new LombardTokenPool(s_token, VERIFIER, address(0), RMN, ROUTER, 18);
 
     assertEq(pool.s_verifier(), VERIFIER);
     assertEq(s_token.allowance(address(pool), VERIFIER), type(uint256).max);
     assertEq(pool.typeAndVersion(), "LombardTokenPool 1.7.0-dev");
   }
-
-  function test_constructor_ZeroVerifierReverts() public {
-    vm.expectRevert(LombardTokenPool.ZeroVerifierNotAllowed.selector);
-    new LombardTokenPool(s_token, address(0), address(0), RMN, ROUTER, 18);
-  }
 }

chains/evm/contracts/test/pools/LombardTokenPool/LombardTokenPool.setVerifier.t.sol

@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: BUSL-1.1
+pragma solidity ^0.8.24;
+
+import {LombardTokenPool} from "../../../pools/Lombard/LombardTokenPool.sol";
+import {LombardTokenPoolSetup} from "./LombardTokenPoolSetup.t.sol";
+
+contract LombardTokenPool_setVerifier is LombardTokenPoolSetup {
+  function test_setVerifier() public {
+    address newVerifier = makeAddr("newVerifier");
+
+    vm.prank(OWNER);
+    s_pool.setVerifier(newVerifier);
+
+    assertEq(s_pool.s_verifier(), newVerifier);
+    assertEq(s_token.allowance(address(s_pool), newVerifier), type(uint256).max);
+    assertEq(s_token.allowance(address(s_pool), VERIFIER), 0);
+  }
+
+  function test_setVerifier_RevertWhen_ZeroVerifierNotAllowed() public {
+    vm.prank(OWNER);
+    vm.expectRevert(LombardTokenPool.ZeroVerifierNotAllowed.selector);
+    s_pool.setVerifier(address(0));
+  }
+}