-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add estimated_size for Block structure #130
Comments
Also: In I think it'd better to use the same name. |
PS: Maybe you could add a Q&A in each section. There must be some questions that have been frequently asked, which you've already answered in discord. |
+1 :) I'd like to postpone API updates to the next major update of the course. I'll leave this open so that I don't forget. |
If you want to add
rather than
|
There has already been a function
estimated_size
inSsTableBuilder
. I think it is fair to add the same function toBlockBuilder
structure:Doing this has two benefits:
estimated_size
inSsTableBuilder
more precise:Because during the process of building table, there may be some data in block builder that are not taken into count.
compact
ofcompact.rs
, we can useestimated_size
ofSsTableBuilder
to find if there are some data left:I have read your code in checkpoint, and I think this eliminates the need to use
Option
as a wrapper ofSsTableBuilder
.The text was updated successfully, but these errors were encountered: