Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

week1_day5 test #126

Open
ppdogg opened this issue Feb 25, 2025 · 1 comment
Open

week1_day5 test #126

ppdogg opened this issue Feb 25, 2025 · 1 comment

Comments

@ppdogg
Copy link
Contributor

ppdogg commented Feb 25, 2025

Insufficient testing for Task 3。

The reason is commented here

I suggest add some modification to the test function test_task3_storage_get:

  1. add a key 10 to sst1
     let sst1 = generate_sst(
        10,
        dir.path().join("10.sst"),
        vec![
            (Bytes::from_static(b"0"), Bytes::from_static(b"233")),
            (Bytes::from_static(b"10"), Bytes::from_static(b"test")),
            (Bytes::from_static(b"00"), Bytes::from_static(b"2333333")),
            (Bytes::from_static(b"4"), Bytes::from_static(b"23")),
        ],
        Some(storage.block_cache.clone()),
    );
  1. try to get the key 10
    assert_eq!(
        storage.get(b"10").unwrap(),
        Some(Bytes::from_static(b"test"))
    );
@ppdogg ppdogg closed this as completed Feb 25, 2025
@skyzh skyzh reopened this Mar 9, 2025
@skyzh
Copy link
Owner

skyzh commented Mar 9, 2025

I'll revisit this issue before closing it, thanks for filing anyways :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants