[REFACTOR] ambiguous namespace, changed.

Gonzalo Diaz · Gonzalo Diaz · commit d9b55591ed95 · 2025-05-14T20:16:58.000-04:00
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.cs
@@ -1,7 +1,7 @@
 // @link Problem definition [[docs/hackerrank/interview_preparation_kit/linked_lists/find-the-merge-point-of-two-joined-linked-lists.md]]
 
 namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list;
-using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;
+using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.common;
 
 using System.Diagnostics.CodeAnalysis;
 
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs
@@ -1,7 +1,7 @@
 // @link Problem definition [[docs/hackerrank/interview_preparation_kit/linked_lists/ctci_linked_list_cycle.md]]
 
 namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list;
-using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;
+using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.common;
 
 using System.Diagnostics.CodeAnalysis;
 
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/common/LinkedListPrinter.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/common/LinkedListPrinter.cs
@@ -1,4 +1,4 @@
-namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;
+namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.common;
 
 public static class LinkedListPrinter
 {
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/common/Node.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/common/Node.cs
@@ -1,4 +1,4 @@
-namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;
+namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.common;
 
 public static class LinkedList<T>
 {
diff --git a/src/algorithm_exercises_csharp_test/common/JsonLoader.cs b/src/algorithm_exercises_csharp_test/common/JsonLoader.cs
@@ -1,4 +1,5 @@
-namespace algorithm_exercises_csharp_test.lib;
+namespace algorithm_exercises_csharp_test.common;
+
 using algorithm_exercises_csharp;
 
 using System.Reflection;
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/ArraysLeftRotation.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/ArraysLeftRotation.Test.cs
@@ -1,23 +1,24 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.arrays;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays;
 
 [TestClass]
 public class ArraysLeftRotationTest
 {
-  public class ArraysLeftRotationsTestCase(int[] input, int d, int[] expected)
+  public class ArraysLeftRotationsTestCase(List<int> input, int d_rotations, List<int> expected)
   {
-    private readonly List<int> input = [.. input];
-    private readonly int d = d;
-    private readonly List<int> expected = [.. expected];
+    private List<int> input = input;
+    private int d_rotations = d_rotations;
+    private List<int> expected = expected;
 
     public List<int> Input
     {
       get { return input; }
     }
-    public int D
+    public int D_rotations
     {
-      get { return d; }
+      get { return d_rotations; }
     }
     public List<int> Expected
     {
@@ -42,7 +43,7 @@ public void testRotLeft()
 
     foreach (ArraysLeftRotationsTestCase test in testCases)
     {
-      result = ArraysLeftRotation.rotLeft(test.Input, test.D);
+      result = ArraysLeftRotation.rotLeft(test.Input, test.D_rotations);
       CollectionAssert.AreEquivalent(test.Expected, result);
     }
   }
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/CrushBruteForce.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/CrushBruteForce.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.arrays;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/CrushOptimized.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/CrushOptimized.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.arrays;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/NewYearChaos.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/NewYearChaos.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.arrays;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/TwoDArray.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/TwoDArray.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.arrays;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTriplets.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTriplets.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTripletsBruteForce.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTripletsBruteForce.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/FrequencyQueries.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/FrequencyQueries.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/RansomNote.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/RansomNote.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
 
 [TestClass]
@@ -54,4 +55,14 @@ public void testCheckMagazine()
       Assert.AreEqual(test.Expected, result);
     }
   }
+
+  [TestMethod]
+  public void testException()
+  {
+#pragma warning disable CA2201 // No provocar tipos de excepción reservados
+    Assert.ThrowsExactly<RansomNote.InvalidValueException>(() => throw new RansomNote.InvalidValueException());
+
+    Assert.ThrowsExactly<RansomNote.InvalidValueException>(() => throw new RansomNote.InvalidValueException("test exception", new Exception("test exception")));
+#pragma warning restore CA2201 // No provocar tipos de excepción reservados
+  }
 }
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/SherlockAndAnagrams.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/SherlockAndAnagrams.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/TwoStrings.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/TwoStrings.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/greedy_algorithms/LuckBalance.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/greedy_algorithms/LuckBalance.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.greedy_algorithms;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.greedy_algorithms;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/greedy_algorithms/MinimumAbsoluteDifferenceInAnArray.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/greedy_algorithms/MinimumAbsoluteDifferenceInAnArray.Test.cs
@@ -1,5 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.greedy_algorithms;
-using algorithm_exercises_csharp_test.lib;
+
+using algorithm_exercises_csharp_test.common;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.greedy_algorithms;
 
 [TestClass]
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.Test.cs
@@ -1,6 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.linked_list;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list;
-using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;
+using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.common;
 
 [TestClass]
 public class FindMergeNodeTest
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs
@@ -1,6 +1,6 @@
 namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.linked_list;
 using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list;
-using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;
+using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.common;
 
 [TestClass]
 public class LinkedListCycleTest
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/linked_list/common/Node.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/linked_list/common/Node.Test.cs
@@ -1,5 +1,6 @@
-namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.linked_list.lib;
-using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;
+namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.linked_list.common;
+
+using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.common;
 
 [TestClass]
 public class NodeTest
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/warmup/AVeryBigSumTest.cs b/src/algorithm_exercises_csharp_test/hackerrank/warmup/AVeryBigSumTest.cs
@@ -1,7 +1,8 @@
 namespace algorithm_exercises_csharp_test.hackerrank.warmup;
+
 using algorithm_exercises_csharp.hackerrank.warmup;
 
-using algorithm_exercises_csharp_test.lib;
+using algorithm_exercises_csharp_test.common;
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/warmup/BirthdayCakeCandles.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/warmup/BirthdayCakeCandles.Test.cs
@@ -1,7 +1,8 @@
 namespace algorithm_exercises_csharp_test.hackerrank.warmup;
+
 using algorithm_exercises_csharp.hackerrank.warmup;
 
-using algorithm_exercises_csharp_test.lib;
+using algorithm_exercises_csharp_test.common;
 
 [TestClass]
 public class BirthdayCakeCandlesTest
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/warmup/CompareTriplets.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/warmup/CompareTriplets.Test.cs
@@ -1,7 +1,8 @@
 namespace algorithm_exercises_csharp_test.hackerrank.warmup;
+
 using algorithm_exercises_csharp.hackerrank.warmup;
 
-using algorithm_exercises_csharp_test.lib;
+using algorithm_exercises_csharp_test.common;
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/warmup/DiagonalDifference.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/warmup/DiagonalDifference.Test.cs
@@ -1,7 +1,8 @@
 namespace algorithm_exercises_csharp_test.hackerrank.warmup;
+
 using algorithm_exercises_csharp.hackerrank.warmup;
 
-using algorithm_exercises_csharp_test.lib;
+using algorithm_exercises_csharp_test.common;
 
 [TestClass]
 public class DiagonalDifferenceTest
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/warmup/MiniMaxSum.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/warmup/MiniMaxSum.Test.cs
@@ -1,7 +1,8 @@
 namespace algorithm_exercises_csharp_test.hackerrank.warmup;
+
 using algorithm_exercises_csharp.hackerrank.warmup;
 
-using algorithm_exercises_csharp_test.lib;
+using algorithm_exercises_csharp_test.common;
 
 [TestClass]
 public class MiniMaxSumTest
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/warmup/SimpleArraySum.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/warmup/SimpleArraySum.Test.cs
@@ -1,7 +1,8 @@
 namespace algorithm_exercises_csharp_test.hackerrank.warmup;
+
 using algorithm_exercises_csharp.hackerrank.warmup;
 
-using algorithm_exercises_csharp_test.lib;
+using algorithm_exercises_csharp_test.common;
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
diff --git a/src/algorithm_exercises_csharp_test/hackerrank/warmup/TimeConversion.Test.cs b/src/algorithm_exercises_csharp_test/hackerrank/warmup/TimeConversion.Test.cs
@@ -1,7 +1,8 @@
 namespace algorithm_exercises_csharp_test.hackerrank.warmup;
+
 using algorithm_exercises_csharp.hackerrank.warmup;
 
-using algorithm_exercises_csharp_test.lib;
+using algorithm_exercises_csharp_test.common;
 
 [TestClass]
 public class TimeConversionTest

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;`
	`1`	`+namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.common;`
`2`	`2`
`3`	`3`	`public static class LinkedListPrinter`
`4`	`4`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,23 +1,24 @@`
`1`	`1`	`namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.arrays;`
`2`		`-using algorithm_exercises_csharp_test.lib;`
	`2`	`+`
	`3`	`+using algorithm_exercises_csharp_test.common;`
`3`	`4`	`using algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays;`
`4`	`5`
`5`	`6`	`[TestClass]`
`6`	`7`	`public class ArraysLeftRotationTest`
`7`	`8`	`{`
`8`		`- public class ArraysLeftRotationsTestCase(int[] input, int d, int[] expected)`
	`9`	`+ public class ArraysLeftRotationsTestCase(List<int> input, int d_rotations, List<int> expected)`
`9`	`10`	`{`
`10`		`- private readonly List<int> input = [.. input];`
`11`		`- private readonly int d = d;`
`12`		`- private readonly List<int> expected = [.. expected];`
	`11`	`+ private List<int> input = input;`
	`12`	`+ private int d_rotations = d_rotations;`
	`13`	`+ private List<int> expected = expected;`
`13`	`14`
`14`	`15`	`public List<int> Input`
`15`	`16`	`{`
`16`	`17`	`get { return input; }`
`17`	`18`	`}`
`18`		`- public int D`
	`19`	`+ public int D_rotations`
`19`	`20`	`{`
`20`		`- get { return d; }`
	`21`	`+ get { return d_rotations; }`
`21`	`22`	`}`
`22`	`23`	`public List<int> Expected`
`23`	`24`	`{`
`@@ -42,7 +43,7 @@ public void testRotLeft()`
`42`	`43`
`43`	`44`	`foreach (ArraysLeftRotationsTestCase test in testCases)`
`44`	`45`	`{`
`45`		`- result = ArraysLeftRotation.rotLeft(test.Input, test.D);`
	`46`	`+ result = ArraysLeftRotation.rotLeft(test.Input, test.D_rotations);`
`46`	`47`	`CollectionAssert.AreEquivalent(test.Expected, result);`
`47`	`48`	`}`
`48`	`49`	`}`