Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Heplify error messages for TCP connections #304

Closed
Dletta opened this issue Sep 30, 2024 · 1 comment
Closed

Improve Heplify error messages for TCP connections #304

Dletta opened this issue Sep 30, 2024 · 1 comment

Comments

@Dletta
Copy link
Contributor

Dletta commented Sep 30, 2024

Some error messages can be confusing or with little detail for example:

Sep 30 13:47:27 WGC-HEP-PXY-01 /usr/local/bin/heplify[22187]: sniffer.go:717: closed tcp connection [1]: EOF
Sep 30 13:46:29 WGC-HEP-PXY-02 /usr/local/bin/heplify[16282]: sniffer.go:717: closed tcp connection [1]: EOF

The errors should be more indicative to what this connection is for troubleshooting the cause of early socket termination.

For example, is it an incoming connection to heplify, or is it an outgoing connection from Heplify to Homer?

The error is thrown here for incoming connections:

logp.Err("closed tcp connection [1]: %s", err.Error())

We should consider amending the error to something like below:

Sep 30 13:47:27 WGC-HEP-PXY-01 /usr/local/bin/heplify[22187]: sniffer.go:717: Incoming client closed tcp connection improperly [1]: EOF

@kYroL01
Copy link
Contributor

kYroL01 commented Oct 1, 2024

Fixed by #305

@kYroL01 kYroL01 closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants