Skip to content

Commit 2898776

Browse files
authored
Remove unneccessary Vue.sets (#380)
1 parent 81807e1 commit 2898776

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/stores/courseData.js

+8-9
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const store = new Vuex.Store({
5353
mutations: {
5454
addClass (state, newClass) {
5555
state.roads[state.activeRoad].contents.selectedSubjects[newClass.semester].push(newClass);
56-
Vue.set(state.roads[state.activeRoad], 'changed', moment().format(DATE_FORMAT));
56+
state.roads[state.activeRoad].changed = moment().format(DATE_FORMAT);
5757
},
5858
addFromCard (state, classItem) {
5959
state.addingFromCard = true;
@@ -62,7 +62,6 @@ const store = new Vuex.Store({
6262
addReq (state, event) {
6363
state.roads[state.activeRoad].contents.coursesOfStudy.push(event);
6464
state.roads[state.activeRoad].changed = moment().format(DATE_FORMAT);
65-
Vue.set(state.roads, state.activeRoad, state.roads[state.activeRoad]);
6665
state.fulfillmentNeeded = event;
6766
},
6867
allowCookies (state) {
@@ -98,11 +97,11 @@ const store = new Vuex.Store({
9897
state.roads[state.activeRoad].contents.selectedSubjects[currentClass.semester].splice(classIndex, 1);
9998
currentClass.semester = semester;
10099
state.roads[state.activeRoad].contents.selectedSubjects[semester].push(currentClass);
101-
Vue.set(state.roads[state.activeRoad], 'changed', moment().format(DATE_FORMAT));
100+
state.roads[state.activeRoad].changed = moment().format(DATE_FORMAT);
102101
},
103102
overrideWarnings (state, payload) {
104103
const classIndex = state.roads[state.activeRoad].contents.selectedSubjects[payload.classInfo.semester].indexOf(payload.classInfo);
105-
Vue.set(state.roads[state.activeRoad].contents.selectedSubjects[payload.classInfo.semester][classIndex], 'overrideWarnings', payload.override);
104+
state.roads[state.activeRoad].contents.selectedSubjects[payload.classInfo.semester][classIndex].overrideWarnings = payload.override;
106105
},
107106
setUnretrieved (state, roadIDs) {
108107
state.unretrieved = roadIDs;
@@ -200,12 +199,12 @@ const store = new Vuex.Store({
200199
},
201200
removeClass (state, { classInfo, classIndex }) {
202201
state.roads[state.activeRoad].contents.selectedSubjects[classInfo.semester].splice(classIndex, 1);
203-
Vue.set(state.roads[state.activeRoad], 'changed', moment().format(DATE_FORMAT));
202+
state.roads[state.activeRoad].changed = moment().format(DATE_FORMAT);
204203
},
205204
removeReq (state, event) {
206205
const reqIndex = state.roads[state.activeRoad].contents.coursesOfStudy.indexOf(event);
207206
state.roads[state.activeRoad].contents.coursesOfStudy.splice(reqIndex, 1);
208-
Vue.set(state.roads[state.activeRoad], 'changed', moment().format(DATE_FORMAT));
207+
state.roads[state.activeRoad].changed = moment().format(DATE_FORMAT);
209208
state.fulfillmentNeeded = 'none';
210209
},
211210
resetID (state, { oldid, newid }) {
@@ -249,8 +248,8 @@ const store = new Vuex.Store({
249248
state.roads = roads;
250249
},
251250
setRoadName (state, { id, name }) {
252-
Vue.set(state.roads[id], 'name', name);
253-
Vue.set(state.roads[id], 'changed', moment().format(DATE_FORMAT));
251+
state.roads[id].name = name;
252+
state.roads[id].changed = moment().format(DATE_FORMAT);
254253
},
255254
setSubjectsInfo (state, data) {
256255
state.subjectsInfo = data;
@@ -260,7 +259,7 @@ const store = new Vuex.Store({
260259
},
261260
updateProgress (state, progress) {
262261
Vue.set(state.roads[state.activeRoad].contents.progressOverrides, progress.listID, progress.progress);
263-
Vue.set(state.roads[state.activeRoad], 'changed', moment().format(DATE_FORMAT));
262+
state.roads[state.activeRoad].changed = moment().format(DATE_FORMAT);
264263
},
265264
setFromLocalStorage (state, localStore) {
266265
store.replaceState(localStore);

0 commit comments

Comments
 (0)