Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullPage is not working and causing zombie process #50

Open
johnyvelho opened this issue Aug 29, 2020 · 2 comments
Open

fullPage is not working and causing zombie process #50

johnyvelho opened this issue Aug 29, 2020 · 2 comments

Comments

@johnyvelho
Copy link

johnyvelho commented Aug 29, 2020

https://github.com/sindresorhus/capture-website/blob/master/index.js#L321
Based on this fullPage statment, is possible to find 3 problems

  1. it will never get inside the while loop. bodyBoundingHeight is an object. the correct should be bodyBoundingHeight.height
  2. waitForNavigation resolves when navigating to a new page. this is always crashing in timeout, never being resolved. (L331)
  3. crashing on the waitForFunction can cause zombie process since it won't get at the page.close() (L351)

I will open a PR for these items

@sindresorhus
Copy link
Owner

// @netrules

@sgtrusty
Copy link
Contributor

These are already resolved in the new PR. Thanks a lot for reporting them, @johnyvelho , I can't believe I missed those before commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants