Skip to content

Commit f8aab60

Browse files
committed
feature (Numbers): Use elegant functions
1 parent 61b158f commit f8aab60

File tree

4 files changed

+7
-26
lines changed

4 files changed

+7
-26
lines changed

snippets/numbers/active_update/Snippet.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package numbers;
22

3-
import com.sinch.sdk.domains.numbers.api.v1.ActiveNumberService;
43
import com.sinch.sdk.domains.numbers.api.v1.NumbersService;
54
import com.sinch.sdk.domains.numbers.models.v1.ActiveNumber;
65
import com.sinch.sdk.domains.numbers.models.v1.VoiceConfiguration;
@@ -14,8 +13,6 @@ public class Snippet {
1413

1514
static void execute(NumbersService numbersService) {
1615

17-
ActiveNumberService activeNumbersService = numbersService.active();
18-
1916
String phoneNumber = "YOUR_phone_number_to_be_updated";
2017
String appId = "YOUR_app_id";
2118
String displayName = "Updated from Sinch Java SDK";
@@ -28,7 +25,7 @@ static void execute(NumbersService numbersService) {
2825
.setVoiceConfiguration(voiceConfiguration)
2926
.build();
3027

31-
ActiveNumber response = activeNumbersService.update(phoneNumber, updateRequest);
28+
ActiveNumber response = numbersService.update(phoneNumber, updateRequest);
3229

3330
LOGGER.info(String.format("Updated number: %s", response));
3431
}

snippets/numbers/available_list/Snippet.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package numbers;
22

3-
import com.sinch.sdk.domains.numbers.api.v1.AvailableNumberService;
43
import com.sinch.sdk.domains.numbers.api.v1.NumbersService;
54
import com.sinch.sdk.domains.numbers.models.v1.NumberType;
65
import com.sinch.sdk.domains.numbers.models.v1.available.request.AvailableNumberListRequest;
@@ -13,18 +12,13 @@ public class Snippet {
1312

1413
static void execute(NumbersService numbersService) {
1514

16-
AvailableNumberService availableNumbersService = numbersService.available();
17-
1815
String regionCode = "US";
1916
NumberType type = NumberType.LOCAL;
2017

2118
AvailableNumberListRequest parameters =
22-
AvailableNumberListRequest.builder()
23-
.setRegionCode(regionCode)
24-
.setType(type)
25-
.build();
19+
AvailableNumberListRequest.builder().setRegionCode(regionCode).setType(type).build();
2620

27-
AvailableNumberListResponse response = availableNumbersService.list(parameters);
21+
AvailableNumberListResponse response = numbersService.searchForAvailableNumbers(parameters);
2822

2923
response
3024
.iterator()

snippets/numbers/rent/Snippet.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package numbers;
22

3-
import com.sinch.sdk.domains.numbers.api.v1.AvailableNumberService;
43
import com.sinch.sdk.domains.numbers.api.v1.NumbersService;
54
import com.sinch.sdk.domains.numbers.models.v1.ActiveNumber;
65
import com.sinch.sdk.domains.numbers.models.v1.SmsConfiguration;
@@ -13,8 +12,6 @@ public class Snippet {
1312

1413
static void execute(NumbersService numbersService) {
1514

16-
AvailableNumberService availableNumbersService = numbersService.available();
17-
1815
// Available numbers list can be retrieved by using list() function from available service, see:
1916
// https://developers.sinch.com/quickstart-getting-started-poc/docs/numbers/getting-started/java-sdk/searchavailable
2017
String phoneNumber = "available_phone_number_to_be_rented";
@@ -24,11 +21,9 @@ static void execute(NumbersService numbersService) {
2421
SmsConfiguration.builder().setServicePlanId(servicePlanId).build();
2522

2623
AvailableNumberRentRequest rentRequest =
27-
AvailableNumberRentRequest.builder()
28-
.setSmsConfiguration(smsConfiguration)
29-
.build();
24+
AvailableNumberRentRequest.builder().setSmsConfiguration(smsConfiguration).build();
3025

31-
ActiveNumber response = availableNumbersService.rent(phoneNumber, rentRequest);
26+
ActiveNumber response = numbersService.rent(phoneNumber, rentRequest);
3227

3328
LOGGER.info(String.format("Rented number: %s", response));
3429
}

snippets/numbers/rent_any/Snippet.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package numbers;
22

3-
import com.sinch.sdk.domains.numbers.api.v1.AvailableNumberService;
43
import com.sinch.sdk.domains.numbers.api.v1.NumbersService;
54
import com.sinch.sdk.domains.numbers.models.v1.ActiveNumber;
65
import com.sinch.sdk.domains.numbers.models.v1.Capability;
@@ -16,24 +15,20 @@ public class Snippet {
1615

1716
static void execute(NumbersService numbersService) {
1817

19-
AvailableNumberService availableNumbersService = numbersService.available();
20-
2118
String servicePlanId = "YOUR_service_plan_id";
2219
String regionCode = "YOUR_region_code";
2320

2421
Capability capability = Capability.SMS;
2522
NumberType numberType = NumberType.LOCAL;
2623

2724
ActiveNumber response =
28-
availableNumbersService.rentAny(
25+
numbersService.rentAny(
2926
AvailableNumberRentAnyRequest.builder()
3027
.setCapabilities(Collections.singletonList(capability))
3128
.setType(numberType)
3229
.setRegionCode(regionCode)
3330
.setSmsConfiguration(
34-
SmsConfiguration.builder()
35-
.setServicePlanId(servicePlanId)
36-
.build())
31+
SmsConfiguration.builder().setServicePlanId(servicePlanId).build())
3732
.build());
3833

3934
LOGGER.info(String.format("Rented number: %s", response));

0 commit comments

Comments
 (0)