chore(api): tidy dead-code and bounds cleanup

Author: waleedlatif1

apps/sim/app/api/v2/lib/response.ts

@@ -166,20 +166,18 @@ export function decodeCursor<T = Record<string, unknown>>(cursor: string): T | n
  * Reads back an offset cursor minted by `encodeCursor({ offset })`.
  *
  * An absent cursor means page one. A cursor that is not valid base64-JSON, or
- * that does not carry a non-negative integer `offset`, is REJECTED rather than
+ * that does not carry a non-negative integer `offset`, is rejected rather than
  * coerced to 0: silently restarting at page one while the caller believes it is
- * paging forward makes a paging client loop over the first page forever.
- *
- * Throwing an `OrchestrationError('validation')` is what the other v2 cursor
- * lists do, and the v2 error policies render it as the canonical 400.
+ * paging forward makes a paging client loop over the first page forever. The v2
+ * error policies render the thrown validation error as the canonical 400.
  */
 export function decodeOffsetCursor(cursor: string | undefined): number {
   if (!cursor) return 0
-  const decoded = decodeCursor<{ offset?: unknown }>(cursor)
-  if (!decoded || !Number.isInteger(decoded.offset) || (decoded.offset as number) < 0) {
+  const offset = decodeCursor<{ offset?: unknown }>(cursor)?.offset
+  if (typeof offset !== 'number' || !Number.isInteger(offset) || offset < 0) {
     throw new OrchestrationError('validation', 'Invalid cursor')
   }
-  return decoded.offset as number
+  return offset
 }
 
 /**

apps/sim/lib/folders/queries.ts

@@ -174,11 +174,10 @@ interface ListActiveFolderRowsOptions {
  * Materializes the workspace's active folder tree for one resource type.
  *
  * The read is always bounded: `maxRows` defaults to `MAX_FOLDERS_PER_WORKSPACE`,
- * the same ceiling folder creation refuses to cross, so a workspace can never
- * legitimately hold more rows than a default call will accept. Exceeding the
- * bound THROWS `FolderCollectionLimitExceededError` — the index is never
- * silently truncated, because a partial path index resolves real folder paths
- * to `undefined` and re-roots resources at the workspace root.
+ * the same ceiling folder creation refuses to cross, so a legitimate workspace
+ * never trips it. Exceeding the bound throws `FolderCollectionLimitExceededError`
+ * rather than truncating, because a partial path index resolves real folder
+ * paths to `undefined` and re-roots resources at the workspace root.
  */
 export async function loadActiveFolderPathIndex(
   workspaceId: string,