refactor(forks): stop projecting a column the source query already pins

`listDeployedWorkflows` filters on `fork_sync_excluded = false` and then
selected the same column, so every row it returned carried `false` by
construction - `SELECT x ... WHERE x = false`. The field only ever varied while
`includeSyncExcluded` could make that predicate drop out, which the previous
commit removed, so it is scaffolding from the reverted override rather than
anything load-bearing.

Keeping it would not have been defensive either. If someone widens that
predicate they have to revisit the projection anyway, and a constant field
hides the coupling between the two instead of enforcing it.

Dropped from the query and from `DeployedWorkflowSummary`. The two write sites
now state the invariant they actually mean: a copy is not a new workflow, so it
is written synced and never takes the target workspace's new-workflow default -
which in an opt-out lineage would land a deliberately synced workflow unsynced
on the other side. That explicit write is kept precisely because it is a
semantic claim, not a read of something the query had already decided.

Untouched: the target-side read in `promote-plan.ts`, which queries target
workflows with no exclusion filter and genuinely varies. That is what keeps a
promote from overwriting a target the user unchecked.

Dropped the copy test for an unsynced source, an input no caller can now
produce, and renamed its sibling to the property that still holds.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: mzxchandra

apps/sim/ee/workspace-forking/lib/copy/copy-workflows.test.ts

@@ -696,21 +696,14 @@ describe('copyWorkflowStateIntoTarget fork-sync inheritance', () => {
   })
 
   /**
-   * The regression the whole opt-in feature hinges on. A copy is the same logical workflow
-   * in another workspace, so it must inherit the SOURCE's participation - never the target
-   * workspace's new-workflow default. In an opt-in workspace the default is "excluded", so
-   * taking it here would land an explicitly-selected source's copy already excluded and
-   * sync would never update it again.
+   * The regression the whole opt-in feature hinges on. A copy is not a new workflow, so it
+   * must never take the TARGET workspace's new-workflow default. In an opt-out lineage that
+   * default is "excluded", so taking it here would land a deliberately synced workflow's
+   * copy already excluded, and sync would never update it again.
    */
-  it('inherits a synced source so the copy keeps syncing', async () => {
+  it('writes a synced copy rather than taking the target workspace default', async () => {
     const rows: Record<string, unknown>[] = []
     await copyWorkflowStateIntoTarget({ ...createParams(false), tx: stubCreateTx(rows) } as never)
     expect(rows[0].forkSyncExcluded).toBe(false)
   })
-
-  it('inherits an unsynced source so an overridden copy does not start syncing back', async () => {
-    const rows: Record<string, unknown>[] = []
-    await copyWorkflowStateIntoTarget({ ...createParams(true), tx: stubCreateTx(rows) } as never)
-    expect(rows[0].forkSyncExcluded).toBe(true)
-  })
 })

apps/sim/ee/workspace-forking/lib/copy/deploy-bridge.ts

@@ -36,12 +36,6 @@ export interface DeployedWorkflowSummary {
   sortOrder: number
   /** Whether the deployed API accepts unauthenticated calls; carried onto sync targets. */
   isPublicApi: boolean
-  /**
-   * The source's own fork-sync participation. A copy inherits it verbatim
-   * (`copy-workflows.ts`), because a copied workflow is the same logical workflow in
-   * another workspace - never the workspace's new-workflow default.
-   */
-  forkSyncExcluded: boolean
 }
 
 /**
@@ -68,7 +62,6 @@ export async function listDeployedWorkflows(
       folderId: workflow.folderId,
       sortOrder: workflow.sortOrder,
       isPublicApi: workflow.isPublicApi,
-      forkSyncExcluded: workflow.forkSyncExcluded,
     })
     .from(workflow)
     .where(

apps/sim/ee/workspace-forking/lib/create-fork.ts

@@ -472,7 +472,11 @@ export async function createFork(params: CreateForkParams): Promise<CreateForkRe
           description: wf.description,
           folderId: wf.folderId,
           sortOrder: wf.sortOrder,
-          forkSyncExcluded: wf.forkSyncExcluded,
+          // A copy, not a new workflow, so it must not take the child's new-workflow
+          // default. `listDeployedWorkflows` admits only synced sources, so a copy is
+          // synced too - stated here rather than read back from a projection the source
+          // query has already pinned to false.
+          forkSyncExcluded: false,
         },
         workflowIdMap,
         folderIdMap,

apps/sim/ee/workspace-forking/lib/promote/promote-plan.ts

@@ -42,7 +42,13 @@ export interface ForkPromotePlanItem {
     sortOrder: number
     /** Source's public-API flag, carried onto the written target (see copyWorkflowStateIntoTarget). */
     isPublicApi: boolean
-    /** Source's fork-sync participation, inherited by a promote-created target. */
+    /**
+     * The sync participation a promote-created target is written with. Always false:
+     * `listDeployedWorkflows` admits only synced sources, so a promoted workflow is one.
+     * Stated explicitly so a created target can never take the TARGET workspace's
+     * new-workflow default, which in an opt-out lineage would land a deliberately synced
+     * workflow unsynced on the other side.
+     */
     forkSyncExcluded: boolean
   }
 }
@@ -215,7 +221,7 @@ export function buildForkPromotePlanItems(params: {
         folderId: source.folderId,
         sortOrder: source.sortOrder,
         isPublicApi: source.isPublicApi,
-        forkSyncExcluded: source.forkSyncExcluded,
+        forkSyncExcluded: false,
       },
     })
   }