fix(forks): report a sync's resource copy on its push or pull row instead of a separate Fork entry

Author: icecrasher321

apps/docs/content/docs/platform/enterprise/forks.mdx

@@ -136,7 +136,7 @@ The setting belongs to **this workspace's copy** only. Excluding a workflow here
 
 <Image src="/static/enterprise/forks-activity.png" alt="Activity view showing Fork and Push events with expandable detail rows" width={900} height={614} />
 
-Expand a row for names of workflows and resources that were created, updated, or archived, and any warnings (for example failed background copies or deploy failures).
+Expand a row for names of workflows and resources that were created, updated, or archived, and any warnings (for example failed background copies or deploy failures). A push or pull that copies resources fills their content in the background, and that progress and outcome show in the same row.
 
 ---
 

apps/sim/app/api/workspaces/[id]/fork/promote/route.test.ts

@@ -1,5 +1,5 @@
 /**
- * Tests for the fork sync (promote) route's error projection.
+ * Tests for the fork sync (promote) route's error projection and input mapping.
  *
  * `promoteFork` returns its deliberate refusals as a `blocked` result, but a classified
  * failure raised deeper in the copy — the target workspace's folder ceiling being full —
@@ -12,22 +12,19 @@ import { auditMock, authMockFns, createMockRequest, type MockUser } from '@sim/t
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { FolderCollectionFullError } from '@/lib/folders/errors'
 
-const { mockLogger, mockPromoteFork, mockAssertCanPromote, mockRecordBackgroundWork } = vi.hoisted(
-  () => ({
-    mockLogger: {
-      info: vi.fn(),
-      warn: vi.fn(),
-      error: vi.fn(),
-      debug: vi.fn(),
-      trace: vi.fn(),
-      fatal: vi.fn(),
-      child: vi.fn(),
-    },
-    mockPromoteFork: vi.fn(),
-    mockAssertCanPromote: vi.fn(),
-    mockRecordBackgroundWork: vi.fn(),
-  })
-)
+const { mockLogger, mockPromoteFork, mockAssertCanPromote } = vi.hoisted(() => ({
+  mockLogger: {
+    info: vi.fn(),
+    warn: vi.fn(),
+    error: vi.fn(),
+    debug: vi.fn(),
+    trace: vi.fn(),
+    fatal: vi.fn(),
+    child: vi.fn(),
+  },
+  mockPromoteFork: vi.fn(),
+  mockAssertCanPromote: vi.fn(),
+}))
 
 vi.mock('@sim/audit', () => auditMock)
 vi.mock('@sim/logger', () => ({
@@ -39,9 +36,6 @@ vi.mock('@/ee/workspace-forking/lib/promote/promote', () => ({ promoteFork: mock
 vi.mock('@/ee/workspace-forking/lib/lineage/authz', () => ({
   assertCanPromote: mockAssertCanPromote,
 }))
-vi.mock('@/ee/workspace-forking/lib/background-work/store', () => ({
-  recordBackgroundWork: mockRecordBackgroundWork,
-}))
 
 import { POST } from '@/app/api/workspaces/[id]/fork/promote/route'
 
@@ -69,8 +63,41 @@ describe('POST /api/workspaces/[id]/fork/promote', () => {
       edge: { childWorkspaceId: WORKSPACE_ID },
       sourceWorkspaceId: WORKSPACE_ID,
       targetWorkspaceId: 'ws-parent',
+      source: { name: 'Child' },
+      target: { name: 'Parent' },
+    })
+  })
+
+  /**
+   * The sync's Activity row is recorded by the use case, not here, so the route's job is to
+   * hand it the one thing only the route knows: the display name of the edge's other side.
+   */
+  it('names the other side of the edge for promoteFork to record the sync', async () => {
+    mockPromoteFork.mockResolvedValue({
+      promoteRunId: 'run-1',
+      updated: 1,
+      created: 0,
+      archived: 0,
+      redeployed: 1,
+      deployFailed: 0,
+      unmappedRequired: [],
+      blockers: [],
+      blocked: null,
+      updatedNames: ['Flow'],
+      createdNames: [],
+      archivedNames: [],
+      needsConfiguration: [],
+      clearedOptional: [],
+      droppedReferences: [],
+      triggerUrlChanges: [],
     })
-    mockRecordBackgroundWork.mockResolvedValue(undefined)
+
+    const response = await POST(promoteRequest(), routeContext)
+
+    expect(response.status).toBe(200)
+    expect(mockPromoteFork).toHaveBeenCalledWith(
+      expect.objectContaining({ direction: 'push', actorName: 'A', otherWorkspaceName: 'Parent' })
+    )
   })
 
   it('renders a full-folder-tree refusal as an actionable 409', async () => {

apps/sim/app/api/workspaces/[id]/fork/promote/route.ts

@@ -1,15 +1,12 @@
 import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
-import { db } from '@sim/db'
 import { createLogger } from '@sim/logger'
-import { getErrorMessage } from '@sim/utils/errors'
 import { type NextRequest, NextResponse } from 'next/server'
 import { promoteForkContract } from '@/lib/api/contracts/workspace-fork'
 import { parseRequest } from '@/lib/api/server'
 import { getSession } from '@/lib/auth'
 import { asOrchestrationError, statusForOrchestrationError } from '@/lib/core/orchestration/types'
 import { generateRequestId } from '@/lib/core/utils/request'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
-import { recordBackgroundWork } from '@/ee/workspace-forking/lib/background-work/store'
 import { assertCanPromote } from '@/ee/workspace-forking/lib/lineage/authz'
 import { promoteFork } from '@/ee/workspace-forking/lib/promote/promote'
 
@@ -36,6 +33,8 @@ export const POST = withRouteHandler(
     } = parsed.data.body
 
     const auth = await assertCanPromote(id, otherWorkspaceId, direction, session.user.id)
+    const otherName =
+      otherWorkspaceId === auth.sourceWorkspaceId ? auth.source.name : auth.target.name
 
     let result: Awaited<ReturnType<typeof promoteFork>>
     try {
@@ -46,6 +45,7 @@ export const POST = withRouteHandler(
         direction,
         userId: session.user.id,
         actorName: session.user.name ?? undefined,
+        otherWorkspaceName: otherName,
         dependentValues,
         copyResources,
         dropReferences,
@@ -114,44 +114,6 @@ export const POST = withRouteHandler(
       request: req,
     })
 
-    const otherName =
-      otherWorkspaceId === auth.sourceWorkspaceId ? auth.source.name : auth.target.name
-    await recordBackgroundWork(db, {
-      workspaceId: id,
-      kind: 'fork_sync',
-      status:
-        result.deployFailed > 0 ||
-        result.needsConfiguration.length > 0 ||
-        result.clearedOptional.length > 0 ||
-        result.droppedReferences.length > 0 ||
-        result.triggerUrlChanges.length > 0
-          ? 'completed_with_warnings'
-          : 'completed',
-      message: direction === 'pull' ? `Pulled from "${otherName}"` : `Pushed to "${otherName}"`,
-      metadata: {
-        actorName: session.user.name ?? undefined,
-        otherWorkspaceId,
-        otherWorkspaceName: otherName,
-        direction,
-        updated: result.updated,
-        created: result.created,
-        archived: result.archived,
-        redeployed: result.redeployed,
-        deployFailed: result.deployFailed,
-        updatedNames: result.updatedNames,
-        createdNames: result.createdNames,
-        archivedNames: result.archivedNames,
-        needsConfiguration: result.needsConfiguration,
-        clearedOptional: result.clearedOptional,
-        droppedReferences: result.droppedReferences.length,
-        triggerUrlChanges: result.triggerUrlChanges.length,
-      },
-    }).catch((error) =>
-      logger.error(`[${requestId}] Failed to record sync activity`, {
-        error: getErrorMessage(error),
-      })
-    )
-
     return NextResponse.json(body)
   }
 )

apps/sim/ee/workspace-forking/components/fork-activity-panel/fork-activity-panel.test.tsx

@@ -169,3 +169,72 @@ describe('ForkActivityPanel event badge tooltip', () => {
     expect(row?.getAttribute('aria-expanded')).toBe('false')
   })
 })
+
+describe('ForkActivityPanel sync report', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    container = document.createElement('div')
+    document.body.appendChild(container)
+    root = createRoot(container)
+  })
+
+  afterEach(() => {
+    act(() => root.unmount())
+    container.remove()
+  })
+
+  const syncMetadata = {
+    actorName: 'Brandon Tarr',
+    direction: 'push' as const,
+    otherWorkspaceId: PARTNER_ID,
+    otherWorkspaceName: 'another workspace',
+    updatedNames: ['Flow A'],
+    tables: 2,
+    files: 1,
+  }
+
+  function expandRow() {
+    const row = container.querySelector<HTMLButtonElement>('button[aria-expanded]')
+    if (!row) throw new Error('row is not expandable')
+    act(() => row.click())
+  }
+
+  /**
+   * The reported bug: a push that copied resources showed a second row, badged "Fork", for the
+   * background fill. The fill belongs to the push, so it reads inside the push's own row.
+   */
+  it('shows the background copy inside the push row while it is still running', () => {
+    renderJobs([
+      makeJob({
+        kind: 'fork_sync',
+        workspaceId: WORKSPACE_ID,
+        status: 'processing',
+        metadata: syncMetadata,
+      }),
+    ])
+
+    expect(container.querySelectorAll('button[aria-expanded]')).toHaveLength(1)
+    expect(badgeElement().textContent).toBe('Push')
+    expandRow()
+    expect(container.textContent).toContain('Copying')
+    expect(container.textContent).toContain('2 tables, 1 file')
+  })
+
+  it('reports the finished copy and what it lost on the same row', () => {
+    renderJobs([
+      makeJob({
+        kind: 'fork_sync',
+        workspaceId: WORKSPACE_ID,
+        status: 'completed_with_warnings',
+        message: 'Copied 2 items; 1 could not be copied',
+        metadata: { ...syncMetadata, copied: 2, failed: 1 },
+      }),
+    ])
+
+    expandRow()
+    expect(container.textContent).toContain('Copied')
+    expect(container.textContent).not.toContain('Copying')
+    expect(container.textContent).toContain('2 tables, 1 file')
+    expect(container.textContent).toContain('1 resource failed to copy')
+  })
+})

apps/sim/ee/workspace-forking/components/fork-activity-panel/fork-activity-panel.tsx

@@ -5,7 +5,7 @@ import { Badge, Button, Tooltip } from '@sim/emcn'
 import { createLogger } from '@sim/logger'
 import { formatDateTime } from '@sim/utils/formatting'
 import { truncate } from '@sim/utils/string'
-import type { BackgroundWorkItem } from '@/lib/api/contracts/workspace-fork'
+import type { BackgroundWorkItem, BackgroundWorkMetadata } from '@/lib/api/contracts/workspace-fork'
 import {
   ActivityLog,
   type ActivityLogEntry,
@@ -31,6 +31,19 @@ function countList(pairs: Array<[number | undefined, string]>): string {
     .join(' · ')
 }
 
+/**
+ * Per-kind counts of the heavy content a fork or sync fills in the background, as "N tables"
+ * segments. A sync's fill records counts only; a fork's row carries names as well.
+ */
+function contentFillCounts(m: NonNullable<BackgroundWorkMetadata>): string[] {
+  const kinds: Array<[number | undefined, string]> = [
+    [m.knowledgeBases, 'knowledge base'],
+    [m.tables, 'table'],
+    [m.files, 'file'],
+  ]
+  return kinds.filter(([n]) => (n ?? 0) > 0).map(([n, noun]) => plural(n as number, noun))
+}
+
 /** A named group (one resource kind or change action) of a job's report. */
 interface ReportGroup {
   label: string
@@ -66,8 +79,9 @@ function jobTitle(job: BackgroundWorkItem, view: ActivityView): string {
   const recordedHere = job.workspaceId === view.workspaceId
   switch (job.kind) {
     case 'fork_content_copy':
-      // A partner-recorded copy row is either this workspace's own creation (recorded
-      // on the parent, carrying our id as the child) or a sync's resource fill.
+      // A partner-recorded copy row is this workspace's own creation (recorded on the parent,
+      // carrying our id as the child). A row with no child is a sync's resource fill from
+      // before those were folded into the sync's own row, and reads by its message.
       if (!recordedHere && m?.childWorkspaceId === view.workspaceId) {
         return `Forked from "${partnerName(job, view)}"`
       }
@@ -160,11 +174,21 @@ function jobReport(job: BackgroundWorkItem): JobReport {
   const addGroup = (label: string, names: string[] | undefined) => {
     if (names && names.length > 0) groups.push({ label, names })
   }
+  const addContentFillWarnings = () => {
+    if (m.failed && m.failed > 0) {
+      notes.push({ value: `${plural(m.failed, 'resource')} failed to copy`, warning: true })
+    }
+    if (m.clearingFailed) {
+      notes.push({ value: 'Reference cleanup incomplete', warning: true })
+    }
+  }
 
   if (job.kind === 'fork_sync') {
     addGroup('Updated', m.updatedNames)
     addGroup('Created', m.createdNames)
     addGroup('Archived', m.archivedNames)
+    // Resources the sync copied have their content filled in the background on this same row.
+    addGroup(job.status === 'processing' ? 'Copying' : 'Copied', contentFillCounts(m))
     // Pre-names entries fall back to the count summary (redeployed mirrors updated).
     if (groups.length === 0) {
       const counts = countList([
@@ -192,6 +216,7 @@ function jobReport(job: BackgroundWorkItem): JobReport {
     if (m.deployFailed && m.deployFailed > 0) {
       notes.push({ value: `${plural(m.deployFailed, 'workflow')} failed to deploy`, warning: true })
     }
+    addContentFillWarnings()
     return { groups, notes }
   }
 
@@ -215,26 +240,16 @@ function jobReport(job: BackgroundWorkItem): JobReport {
   addGroup('Skills', m.skillNames)
   addGroup('MCP servers', m.mcpServerNames)
   addGroup('Workflow MCP servers', m.workflowMcpServerNames)
-  // Sync content-copy rows record per-kind COUNTS only (fork rows carry names), so fall back
-  // to the counts when no named group rendered.
+  // Sync fills recorded before they folded into the sync's own row carry per-kind COUNTS only
+  // (fork rows carry names), so fall back to the counts when no named group rendered.
   if (groups.length === 0) {
     const counts = [
-      [m.workflowsCopied, 'workflow'],
-      [m.knowledgeBases, 'knowledge base'],
-      [m.tables, 'table'],
-      [m.files, 'file'],
-    ]
-      .filter(([n]) => ((n as number | undefined) ?? 0) > 0)
-      .map(([n, noun]) => plural(n as number, noun as string))
-      .join(' · ')
+      ...(m.workflowsCopied ? [plural(m.workflowsCopied, 'workflow')] : []),
+      ...contentFillCounts(m),
+    ].join(' · ')
     if (counts) notes.push({ value: counts })
   }
-  if (m.failed && m.failed > 0) {
-    notes.push({ value: `${plural(m.failed, 'resource')} failed to copy`, warning: true })
-  }
-  if (m.clearingFailed) {
-    notes.push({ value: 'Reference cleanup incomplete', warning: true })
-  }
+  addContentFillWarnings()
   return { groups, notes }
 }