fix: address review — export audit timing, copilot delete signal, group reset

- Table export (Cursor MED): audit fires before streaming begins, not after
  controller.close(), so a mid-stream failure still records the partial export.
- deleteCopilotFile (Greptile P1): throw when storage accounting can't be settled
  instead of silently returning, so callers can detect the file was not deleted.
- workspace-scope-sync (Cursor MED): only resetGroups() once workspace metadata is
  loaded (activeWorkspace present), so a team workspace doesn't transiently lose
  its org group while organizationId is still null during load.

Author: waleedlatif1

apps/sim/app/api/table/[tableId]/export/route.ts

@@ -56,6 +56,29 @@ export const GET = withRouteHandler(async (request: NextRequest, { params }: Rou
   const safeName = sanitizeFilename(table.name)
   const filename = `${safeName}.${format}`
 
+  // Record the export before streaming begins. Rows leave the server incrementally,
+  // so a mid-stream failure would still exfiltrate partial data — auditing here
+  // (after access is granted) guarantees every authorized export is recorded.
+  recordAudit({
+    workspaceId: table.workspaceId ?? null,
+    actorId: userId,
+    action: AuditAction.TABLE_EXPORTED,
+    resourceType: AuditResourceType.TABLE,
+    resourceId: tableId,
+    resourceName: table.name,
+    description: `Exported table "${table.name}" as ${format.toUpperCase()}`,
+    metadata: { format, rowCount: table.rowCount },
+    request,
+  })
+  if (table.workspaceId) {
+    captureServerEvent(
+      userId,
+      'table_exported',
+      { table_id: tableId, workspace_id: table.workspaceId },
+      { groups: { workspace: table.workspaceId } }
+    )
+  }
+
   const stream = new ReadableStream<Uint8Array>({
     async start(controller) {
       const encoder = new TextEncoder()
@@ -101,26 +124,6 @@ export const GET = withRouteHandler(async (request: NextRequest, { params }: Rou
           format,
           rowCount: table.rowCount,
         })
-
-        recordAudit({
-          workspaceId: table.workspaceId ?? null,
-          actorId: userId,
-          action: AuditAction.TABLE_EXPORTED,
-          resourceType: AuditResourceType.TABLE,
-          resourceId: tableId,
-          resourceName: table.name,
-          description: `Exported table "${table.name}" as ${format.toUpperCase()}`,
-          metadata: { format, rowCount: table.rowCount },
-          request,
-        })
-        if (table.workspaceId) {
-          captureServerEvent(
-            userId,
-            'table_exported',
-            { table_id: tableId, workspace_id: table.workspaceId },
-            { groups: { workspace: table.workspaceId } }
-          )
-        }
       } catch (err) {
         logger.error(`[${requestId}] Export failed for table ${tableId}`, err)
         controller.error(err)

apps/sim/app/workspace/[workspaceId]/providers/workspace-scope-sync.tsx

@@ -24,15 +24,17 @@ export function WorkspaceScopeSync() {
     if (!workspaceId) return
     if (organizationId) {
       posthog?.group('organization', organizationId)
-    } else {
-      // A personal workspace has no org — drop any organization group carried
-      // over from a previously-active team workspace so later events don't keep
-      // rolling up under it. resetGroups clears all groups, so the workspace
-      // group is re-applied immediately below.
+    } else if (activeWorkspace) {
+      // Metadata is loaded and this workspace genuinely has no org — drop any
+      // organization group carried over from a previously-active team workspace.
+      // While metadata is still loading, activeWorkspace is undefined and
+      // organizationId is transiently null, so resetting here would briefly strip
+      // a team workspace's org group. resetGroups clears all groups, so the
+      // workspace group is re-applied immediately below.
       posthog?.resetGroups()
     }
     posthog?.group('workspace', workspaceId, workspaceName ? { name: workspaceName } : undefined)
-  }, [posthog, workspaceId, workspaceName, organizationId])
+  }, [posthog, workspaceId, workspaceName, organizationId, activeWorkspace])
 
   useEffect(() => {
     if (!workspaceId || hydrationWorkspaceId === workspaceId) {

apps/sim/lib/uploads/contexts/copilot/copilot-file-manager.ts

@@ -280,11 +280,16 @@ export async function deleteCopilotFile(key: string): Promise<void> {
     }
   }
 
-  if (released) {
-    await deleteFile({
-      key,
-      context: 'copilot',
-    })
-    logger.info(`Successfully deleted copilot file: ${key}`)
+  // Accounting couldn't be settled (read or release failed). The file is left
+  // fully intact; throw so the caller knows the deletion did not happen and can
+  // retry, rather than silently reporting success.
+  if (!released) {
+    throw new Error(`Copilot file deletion aborted; storage accounting failed for key: ${key}`)
   }
+
+  await deleteFile({
+    key,
+    context: 'copilot',
+  })
+  logger.info(`Successfully deleted copilot file: ${key}`)
 }