chore(tests): tighten check:test-patterns and shrink its baseline

- Exempt *.live.test.ts from global-remock and local-factory: live suites bind
  real boundaries (real Postgres via a re-mocked @sim/db).
- Fail when a central mock vi.mocks an @/ module id that no longer resolves;
  repoint copilot-http to @/lib/mothership/request/http (renamed in #8208)
  and drop executor.mock's mocks of deleted modules. The check also scans
  vitest.setup.ts, whose mock and alias of the deleted @/stores/console/store
  are removed.
- Gate local-helper on the workspace depending on @sim/testing.
- redundant-hook inspects every afterEach statement and the leading run of a
  beforeEach (a later reset can deliberately discard setup's own calls).
- New module-scope-stub rule: module-scope vi.stubGlobal/stubEnv/spyOn is
  undone before the first test; delete the six dead fetch stubs.
- Rewrite @sim/testing @example barrel imports to direct paths.
- Replace real sleeps with fake timers in file-doc-store and update-cost.
- Convert table-constants and sim-search-connectors local factories to the
  central mocks; fold v1-route's subscription/rate-limiter duplicates into
  billingSubscriptionMock/rateLimiterMock.

Baseline: 140 -> 92 entries.

Author: waleedlatif1

.claude/rules/sim-testing.md

@@ -88,7 +88,8 @@ describe('GET /api/my-route', () => {
 
 `apps/sim/vitest.setup.ts` mocks the modules nearly every test touches. `@sim/testing` holds one
 central mock for every other module that more than a couple of tests mock. Never hand-roll a
-`vi.mock` factory for either — `bun run check:test-patterns` fails on a new one.
+`vi.mock` factory for either — `bun run check:test-patterns` fails on a new one (integration and
+`*.live.test.ts` files bind real boundaries and are exempt).
 
 - **Global module**: don't `vi.mock` it; drive it through its knobs (table below).
 - **Any other module**: find its central mock by copying an existing use —
@@ -161,7 +162,8 @@ The suite's wall time is bound by the single Vite server thread that serves ever
 
 1. `vi.hoisted()` + `vi.mock()` + static imports. Never `vi.resetModules()` + `vi.doMock()` +
    dynamic `import()`, except for a module that caches a singleton at module scope.
-2. Never `vi.importActual()`/`importOriginal` to build a partial mock — use the central mock.
+2. Build a partial mock with `vi.importActual()`/`importOriginal` only for a module with no central
+   mock; otherwise use the central mock.
 3. Mock heavy graphs a test does not need and the setup does not already mock: `@/blocks`,
    `@/triggers/registry`, `@/tools/generated/*`.
 4. No real timers: `vi.useFakeTimers()`, `flushMicrotasks()`, or `flushMacrotask()`.

.cursor/rules/sim-testing.mdc

@@ -86,7 +86,8 @@ describe('GET /api/my-route', () => {
 
 `apps/sim/vitest.setup.ts` mocks the modules nearly every test touches. `@sim/testing` holds one
 central mock for every other module that more than a couple of tests mock. Never hand-roll a
-`vi.mock` factory for either — `bun run check:test-patterns` fails on a new one.
+`vi.mock` factory for either — `bun run check:test-patterns` fails on a new one (integration and
+`*.live.test.ts` files bind real boundaries and are exempt).
 
 - **Global module**: don't `vi.mock` it; drive it through its knobs (table below).
 - **Any other module**: find its central mock by copying an existing use —
@@ -159,7 +160,8 @@ The suite's wall time is bound by the single Vite server thread that serves ever
 
 1. `vi.hoisted()` + `vi.mock()` + static imports. Never `vi.resetModules()` + `vi.doMock()` +
    dynamic `import()`, except for a module that caches a singleton at module scope.
-2. Never `vi.importActual()`/`importOriginal` to build a partial mock — use the central mock.
+2. Build a partial mock with `vi.importActual()`/`importOriginal` only for a module with no central
+   mock; otherwise use the central mock.
 3. Mock heavy graphs a test does not need and the setup does not already mock: `@/blocks`,
    `@/triggers/registry`, `@/tools/generated/*`.
 4. No real timers: `vi.useFakeTimers()`, `flushMicrotasks()`, or `flushMacrotask()`.

apps/desktop/src/main/terminal/shell-startup.test.ts

@@ -76,7 +76,6 @@ afterEach(() => {
   pty.emit = null
   pty.exit = null
   pty.writes.length = 0
-  vi.unstubAllEnvs()
 })
 
 describe('a shell that is still starting', () => {

apps/realtime/src/handlers/file-doc-store.test.ts

@@ -423,23 +423,29 @@ describe('FileDocStore', () => {
    * The loop must back off instead, and re-open a client that was closed rather than reading a dead one.
    */
   it('backs off and re-opens the reader when its connection is closed, instead of spinning', async () => {
-    const store = await newStore()
-    const doc = new Y.Doc()
-    await store.attachRoom(NAME, doc)
-    state.backing!.readerClosed = true
-
-    state.backing!.connects = 0 // ignore the two `init` connects; count only recovery attempts
-    const before = state.backing!.reads
-    await sleep(3000)
-    const attempts = state.backing!.reads - before
-
-    // A fixed 500ms retry manages 6–7 attempts in this window; backing off (500 → 1s → 2s → …) manages
-    // about 3. Exact counts are timing-dependent, so assert the property — it slowed down — not a number.
-    expect(attempts).toBeGreaterThan(0)
-    expect(attempts).toBeLessThanOrEqual(4)
-    // …and it tried to bring the connection back rather than leaving the tailer dead forever.
-    expect(state.backing!.connects).toBeGreaterThan(0)
-    doc.destroy()
+    // Faked before `init` so the reader loop's first sleep already runs on the fake clock.
+    vi.useFakeTimers()
+    try {
+      const store = await newStore()
+      const doc = new Y.Doc()
+      await store.attachRoom(NAME, doc)
+      state.backing!.readerClosed = true
+
+      state.backing!.connects = 0 // ignore the two `init` connects; count only recovery attempts
+      const before = state.backing!.reads
+      await vi.advanceTimersByTimeAsync(3000)
+      const attempts = state.backing!.reads - before
+
+      // A fixed 500ms retry manages 6 attempts in this window; backing off (500 → 1s → 2s → …)
+      // manages about 3. The ±20% jitter moves the exact count, so assert that it slowed down.
+      expect(attempts).toBeGreaterThan(0)
+      expect(attempts).toBeLessThanOrEqual(4)
+      // …and it tried to bring the connection back rather than leaving the tailer dead forever.
+      expect(state.backing!.connects).toBeGreaterThan(0)
+      doc.destroy()
+    } finally {
+      vi.useRealTimers()
+    }
   })
 
   it('elects exactly one seeder across tasks (no split-brain seed)', async () => {

apps/sim/app/api/billing/update-cost/route.test.ts

@@ -17,7 +17,7 @@ import {
 import { copilotHttpMock, copilotHttpMockFns } from '@sim/testing/mocks/copilot-http.mock'
 import { mothershipOtelMock } from '@sim/testing/mocks/mothership-otel.mock'
 import { sleep } from '@sim/utils/helpers'
-import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
+import { afterAll, afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const {
   mockCheckAndBillOverageThreshold,
@@ -1255,58 +1255,73 @@ describe('POST /api/billing/update-cost — mid-run usage gate', () => {
     expect(body.usageExceeded).toBe(false)
   })
 
-  it('answers not exceeded when the standing read outlasts the callback budget', async () => {
-    mockCheckAttributedUsageLimits.mockImplementation(async () => {
-      await sleep(1500)
-      return { isExceeded: true, scope: 'payer' }
+  describe('on a fake clock', () => {
+    beforeEach(() => {
+      // Only the clock the deadline and period checks read, so mocked I/O still settles.
+      vi.useFakeTimers({ toFake: ['setTimeout', 'clearTimeout', 'Date'] })
     })
-    const startedAt = Date.now()
 
-    const res = await POST(attributedCallback())
+    afterEach(() => {
+      vi.useRealTimers()
+    })
 
-    expect(res.status).toBe(200)
-    await expect(res.json()).resolves.toMatchObject({ success: true, usageExceeded: false })
-    expect(Date.now() - startedAt).toBeLessThan(1400)
-  })
+    it('answers not exceeded when the standing read outlasts the callback budget', async () => {
+      mockCheckAttributedUsageLimits.mockImplementation(async () => {
+        await sleep(1500)
+        return { isExceeded: true, scope: 'payer' }
+      })
 
-  it('does not pause a run on a verdict read across the end of its period', async () => {
-    const straddling = {
-      ...CURRENT_ATTRIBUTION,
-      billingPeriod: {
-        start: '2026-07-01T00:00:00.000Z',
-        end: new Date(Date.now() + 40).toISOString(),
-        source: 'stripe' as const,
-      },
-    }
-    mockRefreshAttributionPeriod.mockResolvedValue(straddling)
-    mockCheckAttributedUsageLimits.mockImplementation(async () => {
-      await sleep(80)
-      return { isExceeded: true, scope: 'payer' }
+      const pending = POST(attributedCallback())
+      await vi.advanceTimersByTimeAsync(1000)
+      const res = await pending
+
+      expect(res.status).toBe(200)
+      await expect(res.json()).resolves.toMatchObject({ success: true, usageExceeded: false })
+      // Settle the abandoned read so no later test coalesces onto it.
+      await vi.advanceTimersByTimeAsync(500)
     })
 
-    const body = await (await POST(attributedCallback())).json()
+    it('does not pause a run on a verdict read across the end of its period', async () => {
+      const straddling = {
+        ...CURRENT_ATTRIBUTION,
+        billingPeriod: {
+          start: '2026-07-01T00:00:00.000Z',
+          end: new Date(Date.now() + 40).toISOString(),
+          source: 'stripe' as const,
+        },
+      }
+      mockRefreshAttributionPeriod.mockResolvedValue(straddling)
+      mockCheckAttributedUsageLimits.mockImplementation(async () => {
+        await sleep(80)
+        return { isExceeded: true, scope: 'payer' }
+      })
 
-    expect(body.usageExceeded).toBe(false)
-  })
+      const pending = POST(attributedCallback())
+      await vi.advanceTimersByTimeAsync(80)
+      const body = await (await pending).json()
 
-  it('reloads a cached current period once it has ended', async () => {
-    const ending = {
-      ...CURRENT_ATTRIBUTION,
-      billingPeriod: {
-        start: '2026-07-01T00:00:00.000Z',
-        end: new Date(Date.now() + 50).toISOString(),
-      },
-    }
-    mockRefreshAttributionPeriod
-      .mockResolvedValueOnce(ending)
-      .mockResolvedValue(CURRENT_ATTRIBUTION)
-    refuseOnlyCurrentPeriod()
-    await POST(attributedCallback())
-    await sleep(100)
+      expect(body.usageExceeded).toBe(false)
+    })
 
-    const body = await (await POST(attributedCallback())).json()
+    it('reloads a cached current period once it has ended', async () => {
+      const ending = {
+        ...CURRENT_ATTRIBUTION,
+        billingPeriod: {
+          start: '2026-07-01T00:00:00.000Z',
+          end: new Date(Date.now() + 50).toISOString(),
+        },
+      }
+      mockRefreshAttributionPeriod
+        .mockResolvedValueOnce(ending)
+        .mockResolvedValue(CURRENT_ATTRIBUTION)
+      refuseOnlyCurrentPeriod()
+      await POST(attributedCallback())
+      await vi.advanceTimersByTimeAsync(100)
 
-    expect(body.usageExceeded).toBe(true)
+      const body = await (await POST(attributedCallback())).json()
+
+      expect(body.usageExceeded).toBe(true)
+    })
   })
 
   it('keeps a recorded charge successful when the gate read fails', async () => {

apps/sim/app/api/knowledge/utils.test.ts

@@ -146,8 +146,6 @@ function createEmbeddingFetchMock() {
   return vi.fn().mockResolvedValue(createEmbeddingResponse([0.1, 0.3], 'base64'))
 }
 
-vi.stubGlobal('fetch', createEmbeddingFetchMock())
-
 import { processDocumentAsync } from '@/lib/knowledge/documents/service'
 
 describe('Knowledge Utils', () => {
@@ -156,8 +154,6 @@ describe('Knowledge Utils', () => {
     // The document claim gates on the row it writes back, so an unstubbed
     // `returning()` would abort processing before any completion write.
     dbChainMockFns.returning.mockResolvedValue([{ id: 'doc1' }])
-    // `unstubGlobals: true` removes the module-scope fetch stub after the
-    // first test in the worker; re-stub it per test.
     vi.stubGlobal('fetch', createEmbeddingFetchMock())
     // Under `isolate: false` the shared `@/lib/knowledge/embeddings` module may
     // be cached bound to the REAL env module, so reset the real `env` object

apps/sim/app/api/v1/capability-gate.test.ts

@@ -15,28 +15,30 @@
  * projections rather than gates — a route declaring `'none'` withholds fields
  * instead of refusing — and are pinned in `app/api/v1/logs/projection.test.ts`.
  */
-import {
-  permissionGroupScopeMock,
-  permissionGroupScopeMockFns,
-  resetPermissionGroupScopeMock,
-  v1PersonalKeyCredential,
-  v1RateLimitContextModuleMock,
-  v1RateLimiterModuleMock,
-  v1SubscriptionModuleMock,
-  v1WorkspaceKeyCredential,
-} from '@sim/testing'
 import { auditMock } from '@sim/testing/mocks/audit.mock'
+import { billingSubscriptionMock } from '@sim/testing/mocks/billing-subscription.mock'
 import {
   knowledgeServiceMock,
   knowledgeServiceMockFns,
 } from '@sim/testing/mocks/knowledge-service.mock'
+import {
+  permissionGroupScopeMock,
+  permissionGroupScopeMockFns,
+  resetPermissionGroupScopeMock,
+} from '@sim/testing/mocks/permission-group-scope.mock'
 import { permissionsMock, permissionsMockFns } from '@sim/testing/mocks/permissions.mock'
 import { posthogServerMock } from '@sim/testing/mocks/posthog-server.mock'
+import { rateLimiterMock } from '@sim/testing/mocks/rate-limiter.mock'
 import { createMockRequest } from '@sim/testing/mocks/request.mock'
 import { tableMock, tableMockFns } from '@sim/testing/mocks/table.mock'
 import { tableWireMock } from '@sim/testing/mocks/table-wire.mock'
 import { traceStoreMock } from '@sim/testing/mocks/trace-store.mock'
 import { v1LogsMetaMock, v1LogsMetaMockFns } from '@sim/testing/mocks/v1-logs-meta.mock'
+import {
+  v1PersonalKeyCredential,
+  v1RateLimitContextModuleMock,
+  v1WorkspaceKeyCredential,
+} from '@sim/testing/mocks/v1-route.mock'
 import { workflowsOrchestrationMock } from '@sim/testing/mocks/workflows-orchestration.mock'
 import {
   workspaceUploadsMock,
@@ -59,8 +61,8 @@ vi.mock('@/lib/permission-groups/config-scope.server', () => permissionGroupScop
 vi.mock('@/app/api/v1/auth', () => ({ authenticateV1Request: mockAuthenticateV1Request }))
 vi.mock('@/lib/workspaces/permissions/utils', () => permissionsMock)
 vi.mock('@/lib/workspaces/utils', () => workspacesUtilsMock)
-vi.mock('@/lib/billing/core/subscription', () => v1SubscriptionModuleMock)
-vi.mock('@/lib/core/rate-limiter', () => v1RateLimiterModuleMock)
+vi.mock('@/lib/billing/core/subscription', () => billingSubscriptionMock)
+vi.mock('@/lib/core/rate-limiter', () => rateLimiterMock)
 vi.mock('@/lib/api/server/rate-limit-context', () => v1RateLimitContextModuleMock)
 
 vi.mock('@sim/audit', () => auditMock)

apps/sim/app/api/v1/logs/projection.test.ts

@@ -11,20 +11,20 @@
  * either surface stops projecting.
  */
 import { createRouteContext } from '@sim/testing/helpers/http'
+import { billingSubscriptionMock } from '@sim/testing/mocks/billing-subscription.mock'
 import {
   permissionGroupScopeMock,
   permissionGroupScopeMockFns,
   resetPermissionGroupScopeMock,
 } from '@sim/testing/mocks/permission-group-scope.mock'
 import { permissionsMock, permissionsMockFns } from '@sim/testing/mocks/permissions.mock'
+import { rateLimiterMock } from '@sim/testing/mocks/rate-limiter.mock'
 import { createMockRequest } from '@sim/testing/mocks/request.mock'
 import { traceStoreMock, traceStoreMockFns } from '@sim/testing/mocks/trace-store.mock'
 import { v1LogsMetaMock, v1LogsMetaMockFns } from '@sim/testing/mocks/v1-logs-meta.mock'
 import {
   v1PersonalKeyCredential,
   v1RateLimitContextModuleMock,
-  v1RateLimiterModuleMock,
-  v1SubscriptionModuleMock,
   v1WorkspaceKeyCredential,
 } from '@sim/testing/mocks/v1-route.mock'
 import {
@@ -44,8 +44,8 @@ vi.mock('@/lib/permission-groups/config-scope.server', () => permissionGroupScop
 vi.mock('@/app/api/v1/auth', () => ({ authenticateV1Request: mockAuthenticateV1Request }))
 vi.mock('@/lib/workspaces/permissions/utils', () => permissionsMock)
 vi.mock('@/lib/workspaces/utils', () => workspacesUtilsMock)
-vi.mock('@/lib/billing/core/subscription', () => v1SubscriptionModuleMock)
-vi.mock('@/lib/core/rate-limiter', () => v1RateLimiterModuleMock)
+vi.mock('@/lib/billing/core/subscription', () => billingSubscriptionMock)
+vi.mock('@/lib/core/rate-limiter', () => rateLimiterMock)
 vi.mock('@/lib/api/server/rate-limit-context', () => v1RateLimitContextModuleMock)
 vi.mock('@/lib/logs/public-queries', () => ({
   listPublicWorkflowLogs: mockListPublicWorkflowLogs,

apps/sim/app/api/v1/tables/capability-gate.test.ts

@@ -13,20 +13,20 @@
  * row and the governing group config are mocked.
  */
 import { createRouteContext } from '@sim/testing/helpers/http'
+import { billingSubscriptionMock } from '@sim/testing/mocks/billing-subscription.mock'
 import {
   permissionGroupScopeMock,
   permissionGroupScopeMockFns,
   resetPermissionGroupScopeMock,
 } from '@sim/testing/mocks/permission-group-scope.mock'
 import { permissionsMock, permissionsMockFns } from '@sim/testing/mocks/permissions.mock'
+import { rateLimiterMock } from '@sim/testing/mocks/rate-limiter.mock'
 import { createMockRequest } from '@sim/testing/mocks/request.mock'
 import { tableMock, tableMockFns } from '@sim/testing/mocks/table.mock'
 import { tableWireMock } from '@sim/testing/mocks/table-wire.mock'
 import {
   v1PersonalKeyCredential,
   v1RateLimitContextModuleMock,
-  v1RateLimiterModuleMock,
-  v1SubscriptionModuleMock,
   v1WorkspaceKeyCredential,
 } from '@sim/testing/mocks/v1-route.mock'
 import {
@@ -55,8 +55,8 @@ vi.mock('@/lib/permission-groups/config-scope.server', () => permissionGroupScop
 vi.mock('@/app/api/v1/auth', () => ({ authenticateV1Request: mockAuthenticateV1Request }))
 vi.mock('@/lib/workspaces/permissions/utils', () => permissionsMock)
 vi.mock('@/lib/workspaces/utils', () => workspacesUtilsMock)
-vi.mock('@/lib/billing/core/subscription', () => v1SubscriptionModuleMock)
-vi.mock('@/lib/core/rate-limiter', () => v1RateLimiterModuleMock)
+vi.mock('@/lib/billing/core/subscription', () => billingSubscriptionMock)
+vi.mock('@/lib/core/rate-limiter', () => rateLimiterMock)
 vi.mock('@/lib/api/server/rate-limit-context', () => v1RateLimitContextModuleMock)
 vi.mock('@/lib/table', () => tableMock)
 vi.mock('@/lib/table/orchestration', () => ({ performDeleteTable: vi.fn() }))

apps/sim/app/o/[organizationId]/settings/integrations/providers/[connectorType]/page.test.tsx

@@ -1,5 +1,6 @@
 import { authMockFns } from '@sim/testing/mocks/auth.mock'
 import { nextNavigationMock, nextNavigationMockFns } from '@sim/testing/mocks/next-navigation.mock'
+import { simSearchConnectorsMock } from '@sim/testing/mocks/sim-search-connectors.mock'
 import { beforeEach, expect, it, vi } from 'vitest'
 
 const mocks = vi.hoisted(() => ({ authorize: vi.fn() }))
@@ -8,6 +9,7 @@ vi.mock('@/lib/settings/application/organization-section-access', () => ({
 }))
 vi.mock('next/navigation', () => nextNavigationMock)
 vi.mock('@/lib/sim-search/connectors', () => ({
+  ...simSearchConnectorsMock,
   SEARCH_SOURCE_TYPES: [
     ['jira', { name: 'Jira' }],
     ['confluence', { name: 'Confluence' }],