fix(oracle-fusion): preserve resource keys and tighten validation fixtures

Author: waleedlatif1

apps/sim/lib/internal/oracle-fusion-financials/execute-tool.test.ts

@@ -112,22 +112,23 @@ describe('Oracle Fusion Financials provider contract', () => {
     )
   })
 
-  it('keeps an explicit null patch distinct from an omitted field', async () => {
+  it('preserves the opaque resource key and an explicit null patch', async () => {
     fetchProvider.mockResolvedValue(
-      jsonResponse({ Purpose: null, links: self('expenseReports/report-key') })
+      jsonResponse({ Purpose: null, links: self('expenseReports/%20report-key%20') })
     )
     const response = await execute('update_expense_report', {
       expenseReportUniqId: ' report-key ',
       purpose: null,
     })
     expect(response.status).toBe(200)
+    expect(fetchProvider.mock.calls[0][0]).toBe(`${ROOT}expenseReports/%20report-key%20`)
     expect(fetchProvider.mock.calls[0][2]).toMatchObject({
       method: 'PATCH',
       body: '{"Purpose":null}',
     })
     expect((await response.json()).output.expenseReport).toEqual({
       Purpose: null,
-      expenseReportUniqId: 'report-key',
+      expenseReportUniqId: ' report-key ',
     })
   })
 

apps/sim/lib/internal/oracle-fusion-financials/execute-tool.ts

@@ -1,3 +1,5 @@
+import { createLogger } from '@sim/logger'
+import { getErrorMessage } from '@sim/utils/errors'
 import { ZodError } from 'zod'
 import { OracleFusionProviderError } from '@/lib/internal/oracle-fusion/errors'
 import {
@@ -6,10 +8,13 @@ import {
 } from '@/lib/internal/oracle-fusion-financials/operations'
 import type { InternalToolOperationHandler } from '@/lib/internal/tool-operations/types'
 
+const logger = createLogger('OracleFusionFinancialsToolExecution')
+
 export const executeOracleFusionFinancialsTool: InternalToolOperationHandler = async ({
   toolId,
   input,
   signal,
+  requestId,
 }) => {
   signal?.throwIfAborted()
   if (!isOracleFusionFinancialsToolId(toolId)) {
@@ -30,6 +35,13 @@ export const executeOracleFusionFinancialsTool: InternalToolOperationHandler = a
       )
     }
     const validationFailure = error instanceof ZodError
+    if (!validationFailure) {
+      logger.error('Oracle Fusion Financials operation failed', {
+        error: getErrorMessage(error, 'Unknown error'),
+        requestId,
+        toolId,
+      })
+    }
     return Response.json(
       {
         success: false,

apps/sim/lib/internal/oracle-fusion-financials/schema.ts

@@ -235,17 +235,14 @@ const listShape = {
   totalResults: z.boolean().default(false),
 }
 
-const opaqueKeySchema = z
-  .string()
-  .trim()
-  .refine((value) => {
-    try {
-      encodeOracleFusionPathSegment(value)
-      return true
-    } catch {
-      return false
-    }
-  }, 'Oracle opaque key must be one URL path segment')
+const opaqueKeySchema = z.string().refine((value) => {
+  try {
+    encodeOracleFusionPathSegment(value)
+    return true
+  } catch {
+    return false
+  }
+}, 'Oracle opaque key must be one URL path segment')
 
 const decimalIdSchema = z
   .string()

apps/sim/lib/oauth/token-resolution.test.ts

@@ -224,6 +224,8 @@ describe('resolveCredentialAccessToken', () => {
     authenticate.mockResolvedValue(INTERNAL_AUTH)
     resolveManagedPrincipal.mockResolvedValue(EXECUTOR_PRINCIPAL)
     mockGetToolMetadata.mockReturnValue({
+      id: 'gmail_send',
+      params: {},
       oauth: { required: true, provider: 'google', requiredScopes: ['scope-a'] },
     })
   })
@@ -288,7 +290,7 @@ describe('resolveCredentialAccessToken', () => {
 
   it('rejects tools without managed OAuth support', async () => {
     mockResolveOAuthAccountId.mockResolvedValue(MANAGED_RESOLVED)
-    mockGetToolMetadata.mockReturnValue({ oauth: undefined })
+    mockGetToolMetadata.mockReturnValue({ id: 'http_request', params: {}, oauth: undefined })
 
     const result = await resolveCredentialAccessToken({
       requestId: 'req-1',
@@ -309,7 +311,11 @@ describe('resolveCredentialAccessToken', () => {
 
   it('rejects tools whose scope policy is empty', async () => {
     mockResolveOAuthAccountId.mockResolvedValue(MANAGED_RESOLVED)
-    mockGetToolMetadata.mockReturnValue({ oauth: { required: true, provider: 'unknown-provider' } })
+    mockGetToolMetadata.mockReturnValue({
+      id: 'fixture-tool',
+      params: {},
+      oauth: { required: true, provider: 'oracle-fusion' },
+    })
 
     const result = await resolveCredentialAccessToken({
       requestId: 'req-1',
@@ -464,31 +470,34 @@ describe('ordinary tool credential binding', () => {
     ['gmail', 'google-service-account'],
     ['jira', 'atlassian-service-account'],
     ['confluence', 'atlassian-service-account'],
-  ])('accepts the canonical %s service-account provider %s', async (provider, providerId) => {
-    mockGetToolMetadata.mockReturnValue({
-      id: 'fixture-tool',
-      params: {},
-      oauth: { required: true, provider },
-    })
-    mockResolveOAuthAccountId.mockResolvedValue({ ...serviceAccount, providerId })
-    expect(
-      await resolveCredentialAccessToken({
-        requestId: 'binding-test',
-        credentialId: 'credential-1',
-        toolId: 'fixture-tool',
-        authenticate,
+  ] as const)(
+    'accepts the canonical %s service-account provider %s',
+    async (provider, providerId) => {
+      mockGetToolMetadata.mockReturnValue({
+        id: 'fixture-tool',
+        params: {},
+        oauth: { required: true, provider },
       })
-    ).toMatchObject({
-      ok: true,
-      token: { accessToken: 'service-token', credentialType: 'service_account' },
-    })
-  })
+      mockResolveOAuthAccountId.mockResolvedValue({ ...serviceAccount, providerId })
+      expect(
+        await resolveCredentialAccessToken({
+          requestId: 'binding-test',
+          credentialId: 'credential-1',
+          toolId: 'fixture-tool',
+          authenticate,
+        })
+      ).toMatchObject({
+        ok: true,
+        token: { accessToken: 'service-token', credentialType: 'service_account' },
+      })
+    }
+  )
 
   it.each([
     ['gmail', 'google-email', true],
     ['salesforce', 'salesforce-sandbox', true],
     ['salesforce', 'google', false],
-  ])(
+  ] as const)(
     'binds ordinary OAuth %s tokens to the provider (%s)',
     async (provider, providerId, allowed) => {
       mockGetToolMetadata.mockReturnValue({

scripts/check-test-types.baseline.json

@@ -2012,9 +2012,6 @@
     "TS2348": 1,
     "TS2353": 2
   },
-  "apps/sim/lib/oauth/token-resolution.test.ts": {
-    "TS2739": 3
-  },
   "apps/sim/lib/organizations/instance-org.test.ts": {
     "TS2345": 1
   },