fix(logs): keep an output carrying child spans a record when compacting it

Author: waleedlatif1

apps/sim/lib/execution/payloads/serializer.test.ts

@@ -396,6 +396,18 @@ describe('compacting span trees', () => {
     expectSpanTree(compacted?.childTraceSpans)
   })
 
+  it('keeps the output a record when its other fields together exceed the threshold', async () => {
+    const compacted = await compactBlockOutput(
+      { first: 'a'.repeat(600), second: 'b'.repeat(600), childTraceSpans: childWorkflowSpans() },
+      options
+    )
+
+    expect(isLargeValueRef(compacted)).toBe(false)
+    expect(compacted.first).toBe('a'.repeat(600))
+    expect(compacted.second).toBe('b'.repeat(600))
+    expectSpanTree(compacted.childTraceSpans)
+  })
+
   it('keeps a nested child workflow span tree shaped as a tree', async () => {
     const nestedWorkflowSpan: TraceSpan = {
       id: 'nested-workflow',

apps/sim/lib/execution/payloads/serializer.ts

@@ -295,7 +295,8 @@ async function compactTraceSpan(
 /**
  * Compacts a block output, keeping any `childTraceSpans` shaped as a span tree
  * (see {@link compactTraceSpanTree}). Everything else compacts as a normal
- * execution payload.
+ * execution payload, except that an output carrying spans keeps its root so
+ * the spans stay attached to it; its fields still spill individually.
  */
 export async function compactBlockOutput<T>(
   output: T,
@@ -306,12 +307,9 @@ export async function compactBlockOutput<T>(
   }
   const { childTraceSpans, ...rest } = output
   const [compactedRest, compactedSpans] = await Promise.all([
-    compactExecutionPayload(rest, options),
+    compactExecutionPayload(rest, { ...options, preserveRoot: true }),
     compactTraceSpanTree(childTraceSpans, options),
   ])
-  if (!isRecordLike(compactedRest)) {
-    return compactedRest as T
-  }
   return { ...compactedRest, childTraceSpans: compactedSpans } as T
 }