Skip to content

Commit 41a7329

Browse files
committed
chore(media): drop comments that restate the code they annotate
Two narrated the adjacent literal or ternary. The third was orphaned by the deleted validation chain, so TSDoc bound it to ASPECT_TARGETS and documented the wrong declaration; its rationale is in the commit that removed the chain.
1 parent eda1509 commit 41a7329

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

apps/sim/lib/media/ffmpeg.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export const DEFAULT_FFMPEG_TIMEOUT_MS = 5 * 60 * 1000
7474
const PROBE_TIMEOUT_MS = 15 * 1000
7575
const PROBE_MAX_OUTPUT_BYTES = 8 * 1024 * 1024
7676

77-
/** Names the actionable cause: the budget covers all clips, so fewer/shorter inputs is the fix. */
7877
const TIME_BUDGET_EXCEEDED =
7978
'FFmpeg operation exceeded its time budget — try fewer, shorter, or lower-resolution inputs'
8079

@@ -283,12 +282,6 @@ function resolveVolume(value: number, label: string): number {
283282
return value
284283
}
285284

286-
/**
287-
* Each operation validates the options it consumes, at the point of use, so a
288-
* rule has exactly one home. An LLM caller routinely emits surplus parameters,
289-
* so an operation must ignore — never reject over — a value it never reads.
290-
*/
291-
292285
const ASPECT_TARGETS: Record<string, { w: number; h: number }> = {
293286
'16:9': { w: 1920, h: 1080 },
294287
'9:16': { w: 1080, h: 1920 },
@@ -343,7 +336,6 @@ function createOperationLimit(runOptions: FfmpegRunOptions): TimeoutAbortControl
343336
return createTimeoutAbortController(timeoutMs, runOptions.signal)
344337
}
345338

346-
/** Distinguishes "we ran out of time" from "the caller cancelled" for the message. */
347339
function abortError(limit: TimeoutAbortController): Error {
348340
return new Error(limit.isTimedOut() ? TIME_BUDGET_EXCEEDED : 'FFmpeg operation aborted')
349341
}

0 commit comments

Comments
 (0)