fix(landing): match CollectionPage ItemList order and url to the visible filtered/paginated variant

Address round-2 Cursor Bugbot findings on PR #5638:
- buildCollectionPageJsonLd no longer re-sorts the given posts by date -
  ordering is now solely owned by the caller (selectVisiblePosts), so
  featured-row-first render order matches ItemList position order
- buildCollectionPageJsonLd now takes an optional {tag, page} filter
  descriptor and reflects it in the emitted url, instead of always
  pointing at the bare section index regardless of which filtered/
  paginated variant's posts are actually listed in mainEntity

Author: waleedlatif1

apps/sim/app/(landing)/blog/page.tsx

@@ -37,7 +37,8 @@ export default async function BlogIndex({
       page={pageNum}
       tag={tag}
       collectionJsonLd={buildCollectionPageJsonLd(
-        selectVisiblePosts(posts, { tag, page: pageNum })
+        selectVisiblePosts(posts, { tag, page: pageNum }),
+        { tag, page: pageNum }
       )}
     />
   )

apps/sim/app/(landing)/library/page.tsx

@@ -37,7 +37,8 @@ export default async function LibraryIndex({
       page={pageNum}
       tag={tag}
       collectionJsonLd={buildCollectionPageJsonLd(
-        selectVisiblePosts(posts, { tag, page: pageNum })
+        selectVisiblePosts(posts, { tag, page: pageNum }),
+        { tag, page: pageNum }
       )}
     />
   )

apps/sim/lib/blog/seo.ts

@@ -25,8 +25,11 @@ export function buildPostGraphJsonLd(post: ContentMeta) {
   return buildPostGraphJsonLdGeneric(post, BLOG_SECTION)
 }
 
-export function buildCollectionPageJsonLd(posts: ContentMeta[]) {
-  return buildCollectionPageJsonLdGeneric(BLOG_SECTION, posts)
+export function buildCollectionPageJsonLd(
+  posts: ContentMeta[],
+  filter?: { tag?: string; page?: number }
+) {
+  return buildCollectionPageJsonLdGeneric(BLOG_SECTION, posts, filter)
 }
 
 export function buildIndexMetadata(input: { tag?: string; pageNum: number }) {

apps/sim/lib/content/seo.ts

@@ -350,21 +350,36 @@ export function buildAuthorGraphJsonLd(section: ContentSection, author: Author)
 }
 
 /**
- * `mainEntity` lists the section's real, currently-published posts (sourced
- * from the same `getAllPostMeta()` list the index page renders from — never
- * a hardcoded list) so the collection's JSON-LD stays in sync with what's
- * actually on the page.
+ * `mainEntity` lists exactly the posts passed in, in the given order - the
+ * caller (currently `selectVisiblePosts`) is responsible for sourcing them
+ * from the same `getAllPostMeta()` list the index page renders from and for
+ * ordering them to match the visible layout (e.g. featured-row-first), so
+ * this function never re-sorts and can't diverge from what's on the page.
+ *
+ * `tag`/`page` describe which filtered/paginated variant `posts` came from,
+ * so `url` reflects the actual page these `posts` are visible on rather than
+ * always the bare section index - the same variant is `noindex`ed (see
+ * `buildIndexMetadata`), but the graph still shouldn't attribute a partial
+ * list to the unfiltered collection URL.
  */
-export function buildCollectionPageJsonLd(section: ContentSection, posts: ContentMeta[]) {
-  const dateSorted = [...posts].sort(
-    (a, b) => new Date(b.date).getTime() - new Date(a.date).getTime()
-  )
+export function buildCollectionPageJsonLd(
+  section: ContentSection,
+  posts: ContentMeta[],
+  { tag, page }: { tag?: string; page?: number } = {}
+) {
+  const params = [
+    page && page > 1 ? `page=${page}` : null,
+    tag ? `tag=${encodeURIComponent(tag)}` : null,
+  ]
+    .filter(Boolean)
+    .join('&')
+  const url = `${SITE_URL}${section.basePath}${params ? `?${params}` : ''}`
 
   return {
     '@context': 'https://schema.org',
     '@type': 'CollectionPage',
     name: `Sim ${section.name}`,
-    url: `${SITE_URL}${section.basePath}`,
+    url,
     description: section.description,
     publisher: {
       '@type': 'Organization',
@@ -383,7 +398,7 @@ export function buildCollectionPageJsonLd(section: ContentSection, posts: Conten
     },
     mainEntity: {
       '@type': 'ItemList',
-      itemListElement: dateSorted.map((post, index) => ({
+      itemListElement: posts.map((post, index) => ({
         '@type': 'ListItem',
         position: index + 1,
         url: post.canonical,

apps/sim/lib/library/seo.ts

@@ -26,8 +26,11 @@ export function buildPostGraphJsonLd(post: ContentMeta) {
   return buildPostGraphJsonLdGeneric(post, LIBRARY_SECTION)
 }
 
-export function buildCollectionPageJsonLd(posts: ContentMeta[]) {
-  return buildCollectionPageJsonLdGeneric(LIBRARY_SECTION, posts)
+export function buildCollectionPageJsonLd(
+  posts: ContentMeta[],
+  filter?: { tag?: string; page?: number }
+) {
+  return buildCollectionPageJsonLdGeneric(LIBRARY_SECTION, posts, filter)
 }
 
 export function buildIndexMetadata(input: { tag?: string; pageNum: number }) {