Skip to content

Commit f1504ab

Browse files
committed
wip: make gpg.keyname optional in release workflow; update docs
1 parent c94f0e0 commit f1504ab

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.github/workflows/release-on-tag.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,13 @@ jobs:
4545
CENTRAL_USERNAME: ${{ secrets.CENTRAL_USERNAME }}
4646
CENTRAL_PASSWORD: ${{ secrets.CENTRAL_PASSWORD }}
4747
run: |
48-
mvn -B -ntp \
48+
KN="${{ secrets.GPG_KEYNAME }}"
49+
EXTRA=""
50+
if [ -n "$KN" ]; then EXTRA="-Dgpg.keyname=$KN"; fi
51+
mvn -B -ntp -P release \
4952
-Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}" \
50-
-Dgpg.keyname="${{ secrets.GPG_KEYNAME }}" \
51-
-P release clean deploy
53+
$EXTRA \
54+
clean deploy
5255
5356
- name: Configure Git identity
5457
run: |

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ Automated Release (preferred)
8484
- Push a tag named `release/X.Y.Z` (semver, no leading `v`).
8585
- The workflow `.github/workflows/release-on-tag.yml` will:
8686
- Create a GitHub Release for that tag with autogenerated notes.
87-
- Build and deploy artifacts to Maven Central with `-P release` (Central Publishing plugin). Uses `-Dgpg.passphrase=${{ secrets.GPG_PASSPHRASE }}` and `-Dgpg.keyname=${{ secrets.GPG_KEYNAME }}` for signing.
87+
- Build and deploy artifacts to Maven Central with `-P release` (Central Publishing plugin). Uses `-Dgpg.passphrase=${{ secrets.GPG_PASSPHRASE }}` and optionally `-Dgpg.keyname=${{ secrets.GPG_KEYNAME }}` for signing when set.
8888
- Create a branch `release-bot-YYYYMMDD-HHMMSS` at the tagged commit and open a PR back to `main` (no version bumps).
8989

9090
Manual Release (local)

RELEASE-GIST.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,8 @@ jobs:
4040
CENTRAL_USERNAME: ${{ secrets.CENTRAL_USERNAME }}
4141
CENTRAL_PASSWORD: ${{ secrets.CENTRAL_PASSWORD }}
4242
run: |
43-
mvn -B -ntp \
44-
-Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}" \
45-
-Dgpg.keyname="${{ secrets.GPG_KEYNAME }}" \
46-
-P release clean deploy
43+
KN="${{ secrets.GPG_KEYNAME }}"; EXTRA=""; [ -n "$KN" ] && EXTRA="-Dgpg.keyname=$KN";
44+
mvn -B -ntp -P release -Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}" $EXTRA clean deploy
4745
- name: Configure Git identity
4846
run: |
4947
git config user.name "github-actions[bot]"
@@ -65,7 +63,7 @@ jobs:
6563
6664
- CENTRAL_USERNAME, CENTRAL_PASSWORD (Central Portal token)
6765
- GPG_PRIVATE_KEY (ASCII-armored secret key), GPG_PASSPHRASE
68-
- GPG_KEYNAME (fingerprint of the signing key; set by helper script)
66+
- GPG_KEYNAME (optional; fingerprint of signing keyhelper script sets it; if absent, default key is used)
6967
7068
zsh helper (uses gh, gpg) — auto-detects a signing key if not provided:
7169

0 commit comments

Comments
 (0)