fix: Address PR review comments

- Update both GitHub workflows to use Java 24 instead of matrix build
- Add comprehensive INFO logging for HTTP operations and class discovery
- Remove scaffolding test and fix compilation warnings
- Maintain Java 21 compatibility for main library while using Java 24 for tooling

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: simbo1905

.github/workflows/daily-api-tracker.yml

@@ -14,10 +14,10 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v4
 
-    - name: Set up JDK 21
+    - name: Set up JDK 24
       uses: actions/setup-java@v4
       with:
-        java-version: '21'
+        java-version: '24'
         distribution: 'temurin'
 
     - name: Cache Maven dependencies

.github/workflows/maven.yml

@@ -10,18 +10,15 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        java: [ '21', '22', '23', '24' ]
-    name: Build with JDK ${{ matrix.java }}
+    name: Build with JDK 24
 
     steps:
     - uses: actions/checkout@v4
 
-    - name: Set up JDK ${{ matrix.java }}
+    - name: Set up JDK 24
       uses: actions/setup-java@v4
       with:
-        java-version: ${{ matrix.java }}
+        java-version: '24'
         distribution: 'oracle'
 
     - name: Cache Maven dependencies

json-java21-api-tracker/src/main/java/io/github/simbo1905/tracker/ApiTracker.java

@@ -112,7 +112,8 @@ static Set<Class<?>> discoverLocalJsonClasses() {
             }
         }
 
-        LOGGER.info("Discovered " + classes.size() + " classes in JSON API packages");
+        LOGGER.info("Discovered " + classes.size() + " classes in JSON API packages: " + 
+            classes.stream().map(Class::getName).sorted().collect(Collectors.joining(", ")));
         return Collections.unmodifiableSet(classes);
     }
 
@@ -136,7 +137,7 @@ static void scanDirectory(java.io.File directory, String packageName, Set<Class<
                 try {
                     final var clazz = Class.forName(className);
                     classes.add(clazz);
-                    LOGGER.fine(() -> "Found class: " + className);
+                    LOGGER.info("Found class: " + className);
                 } catch (ClassNotFoundException | NoClassDefFoundError e) {
                     LOGGER.fine(() -> "Could not load class: " + className);
                 }
@@ -174,7 +175,7 @@ static void scanJar(java.net.URL jarUrl, String packageName, Set<Class<?>> class
                         try {
                             final var clazz = Class.forName(className);
                             classes.add(clazz);
-                            LOGGER.fine(() -> "Found class in JAR: " + className);
+                            LOGGER.info("Found class in JAR: " + className);
                         } catch (ClassNotFoundException | NoClassDefFoundError e) {
                             LOGGER.fine(() -> "Could not load class from JAR: " + className);
                         }
@@ -212,7 +213,7 @@ static Map<String, String> fetchUpstreamSources(Set<Class<?>> localClasses) {
             final var upstreamPath = mapToUpstreamPath(className);
             final var url = GITHUB_BASE_URL + upstreamPath;
 
-            LOGGER.fine(() -> "Fetching: " + url);
+            LOGGER.info("Fetching upstream source: " + url);
 
             try {
                 final var request = HttpRequest.newBuilder()
@@ -227,20 +228,20 @@ static Map<String, String> fetchUpstreamSources(Set<Class<?>> localClasses) {
                     final var body = response.body();
                     FETCH_CACHE.put(className, body);
                     results.put(className, body);
-                    LOGGER.fine(() -> "Successfully fetched: " + className);
+                    LOGGER.info("Successfully fetched " + body.length() + " chars for: " + className);
                 } else if (response.statusCode() == 404) {
                     final var error = "NOT_FOUND: Upstream file not found (possibly deleted or renamed)";
                     results.put(className, error);
-                    LOGGER.fine(() -> "Not found: " + className);
+                    LOGGER.info("404 Not Found for upstream: " + className + " at " + url);
                 } else {
                     final var error = "HTTP_ERROR: Status " + response.statusCode();
                     results.put(className, error);
-                    LOGGER.warning(() -> "HTTP error for " + className + ": " + response.statusCode());
+                    LOGGER.info("HTTP error " + response.statusCode() + " for " + className + " at " + url);
                 }
             } catch (Exception e) {
                 final var error = "FETCH_ERROR: " + e.getMessage();
                 results.put(className, error);
-                LOGGER.log(Level.WARNING, "Error fetching " + className, e);
+                LOGGER.info("Fetch error for " + className + " at " + url + ": " + e.getMessage());
             }
         }
 

json-java21-api-tracker/src/test/java/io/github/simbo1905/tracker/ApiTrackerTest.java

@@ -80,7 +80,7 @@ void testExtractLocalApiJsonObject() throws ClassNotFoundException {
             assertThat(((JsonString) api.members().get("packageName")).value()).isEqualTo("jdk.sandbox.java.util.json");
 
             assertThat(api.members()).containsKey("isInterface");
-            assertThat(((JsonValue) api.members().get("isInterface"))).isEqualTo(JsonBoolean.of(true));
+            assertThat(api.members().get("isInterface")).isEqualTo(JsonBoolean.of(true));
 
             assertThat(api.members()).containsKey("methods");
             final var methods = (JsonObject) api.members().get("methods");
@@ -94,7 +94,7 @@ void testExtractLocalApiJsonValue() throws ClassNotFoundException {
             final var api = ApiTracker.extractLocalApi(clazz);
 
             assertThat(api.members()).containsKey("isSealed");
-            assertThat(((JsonValue) api.members().get("isSealed"))).isEqualTo(JsonBoolean.of(true));
+            assertThat(api.members().get("isSealed")).isEqualTo(JsonBoolean.of(true));
 
             assertThat(api.members()).containsKey("permits");
             final var permits = (JsonArray) api.members().get("permits");
@@ -203,7 +203,7 @@ void testRunFullComparison() {
             );
 
             // Total classes should be greater than 0
-            final var totalClasses = ((JsonValue) summary.members().get("totalClasses"));
+            final var totalClasses = summary.members().get("totalClasses");
             assertThat(totalClasses).isNotNull();
         }
     }