Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional CMS Pattern Library improvements. #75

Closed
4 of 6 tasks
sabina-talipova opened this issue May 30, 2023 · 1 comment
Closed
4 of 6 tasks

Additional CMS Pattern Library improvements. #75

sabina-talipova opened this issue May 30, 2023 · 1 comment

Comments

@sabina-talipova
Copy link

sabina-talipova commented May 30, 2023

Description

The following improvements need to be made:

  • Replace 4 space indent with a 2 space. ESlint doesn't help.
  • Introduce a new library @storybook/addon-docs to present documentation to the components.
  • Fix / investigate the reasons for some small warnings that happens time to time in browser console when storybook is running.

AC's

  • Component stories have 2 space indent everywhere in the code.
  • @storybook/addon-docs is implemented and all stories that have pre-existing readme doc are using it.
  • If possible there are not any warnings in the console when storybook is running.

PR's

@emteknetnz
Copy link
Member

@sabina-talipova I've approved all the PRs - you can self-merge them once silverstripe/silverstripe-versioned-admin#296 has been merged - we'd want to merge that one first so that builds go green after merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants