Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the 1 branch on this and recipe-core #24

Closed
sminnee opened this issue Feb 19, 2019 · 8 comments
Closed

Delete the 1 branch on this and recipe-core #24

sminnee opened this issue Feb 19, 2019 · 8 comments

Comments

@sminnee
Copy link
Member

sminnee commented Feb 19, 2019

Recipe 1.x is deprecated. The current tags should be retained to avoid breaking people's sites, but no new releases should be made. As such I think we should delete the 1, 1.0, and 1.1 branches.

We should do the same to recipe-core as well.

@sminnee
Copy link
Member Author

sminnee commented Feb 19, 2019

Relate: silverstripe/recipe-core#37

@ScopeyNZ
Copy link

ScopeyNZ commented Feb 19, 2019

We can't delete them until we drop support for those lines. They need to exist as long as we might release new versions from those lines. In saying that we are coming up to that date: 31/03/2019

@chillu
Copy link
Member

chillu commented Feb 19, 2019

+1 on Sam's suggestion. I don't think we explicitly support deprecated 1.x release lines, although this will have to go alongside some comms on how we treat recipes, and potentially decouple more core versions. This should be done at the same time as solving silverstripe/cow#132 (comment)

@unclecheese @tractorcow Thoughts?

@sminnee sminnee changed the title Delete the 1 branch Delete the 1 branch on this and recipe-core Feb 22, 2019
@tractorcow
Copy link

I just popped in to check on some bugs my developers had with upgrading.

The latest 4.1 line of silverstripe/recipe-cms is 4.1.2 (https://github.com/silverstripe/recipe-cms/releases/tag/4.1.2), but there is actually a newer version tagged 1.1.5 (https://github.com/silverstripe/recipe-cms/releases/tag/1.1.5)

If you want to switch to dropping the 1.1 line you might want to make sure the version users need to upgrade to is being properly maintained. :)

@sminnee
Copy link
Member Author

sminnee commented May 22, 2019

Agreed - deleting the 1.1 branch will help avoid this confusion in the future.

@tractorcow
Copy link

Awesome thanks :D

@robbieaverill
Copy link
Contributor

Can we do this now?

@dnsl48
Copy link
Contributor

dnsl48 commented Dec 2, 2019

What exactly needs to be done? AFAIK the branches 1.0 and 1.1 have already been deleted.

@sminnee sminnee closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants