Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out "empty" XML files #34

Open
papeh opened this issue Feb 19, 2020 · 1 comment
Open

Filter out "empty" XML files #34

papeh opened this issue Feb 19, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@papeh
Copy link
Contributor

papeh commented Feb 19, 2020

When adding or updating files, filter and remove xml files that have no localizable strings. For minimum viable product (MVP), find any matches for the XPaths specified in translatable_elements, if any. Bonus points for checking that the specified attributes and elements have content.
@papeh papeh self-assigned this Feb 19, 2020
papeh added a commit that referenced this issue Feb 20, 2020
@papeh
Filter XML Files (#34)
dfa6647 
* If translatable_elements is specified, exclude files with no matching elements or attributes
* Does not check for translatable content in the referenced elements or attributes
papeh added a commit that referenced this issue Feb 21, 2020
@papeh
Filter XML Files (#34)
52fe6df 
* If translatable_elements is specified, exclude files with no matching elements or attributes
* Does not check for translatable content in the referenced elements or attributes
papeh added a commit that referenced this issue Feb 21, 2020
@papeh
Filter XML Files (#34)
38be481 
* If translatable_elements is specified, exclude files with no matching elements or attributes
* Does not check for translatable content in the referenced elements or attributes
jasonleenaylor pushed a commit that referenced this issue Feb 21, 2020
@papeh @jasonleenaylor
Filter XML Files (#34)
6ebd019 
* If translatable_elements is specified, exclude files with no matching elements or attributes
* Does not check for translatable content in the referenced elements or attributes
@papeh
Copy link
Contributor Author

papeh commented Feb 21, 2020

This is mostly working. TODO:

  • check that attributes or elements have content
  • filter files with Type = "xml" regardless of extension

@papeh papeh removed their assignment Feb 21, 2020
@papeh papeh added the good first issue Good for newcomers label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@papeh