Skip to content

java code not strictly required #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lumenkeyes opened this issue May 6, 2025 · 1 comment · Fixed by #33
Closed

java code not strictly required #32

lumenkeyes opened this issue May 6, 2025 · 1 comment · Fixed by #33

Comments

@lumenkeyes
Copy link
Contributor

Per Android Developers, if an apk is created with android:hasCode="false" in the manifest, android's apk tools will happily build it without adding any Java code. Perhaps the check in apk.zig could be turned off with an option? I could submit a PR with a quick change I made, you just have to use it like this:

const apk = android.APK.create(b, android_tools);
apk.hasCode = false;

Can rewrite if you'd like a nicer interface, but would be nice to have some way to turn off the check

@silbinarywolf
Copy link
Owner

Done.

Added follow-up issue to explore adding validation back in here:
#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants