Skip to content

Work out how to lint against u64::pow #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelsproul opened this issue May 24, 2021 · 2 comments
Open

Work out how to lint against u64::pow #2364

michaelsproul opened this issue May 24, 2021 · 2 comments
Labels
A2 consensus An issue/PR that touches consensus code, such as state_processing or block verification.

Comments

@michaelsproul
Copy link
Member

Description

As discussed here #2350 (comment), the disallowed-methods Clippy lint doesn't seem to work for associated functions on primitive types. This lint was originally created by a Lighthouse contributor for #1621, and has been improved by other Clippy contributors since!

To resolve this issue we should put some print statements in Clippy to work out what AST it sees for functions like u64::pow, and then work out how to incorporate detection of those AST nodes.

Version

Rust 1.52.1 (stable)

@michaelsproul michaelsproul added consensus An issue/PR that touches consensus code, such as state_processing or block verification. and removed t Consensus & Verification labels Nov 9, 2022
@Ifechukwudaniel
Copy link

Hey I would love to do this

@michaelsproul
Copy link
Member Author

@Ifechukwudaniel thanks that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 consensus An issue/PR that touches consensus code, such as state_processing or block verification.
Projects
None yet
Development

No branches or pull requests

2 participants