Skip to content

Commit 6a2affb

Browse files
added sonar fixes
1 parent f5b6120 commit 6a2affb

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

src/LCT.Common/TelemetryHelper.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public TelemetryHelper(CommonAppSettings appSettings)
3131

3232
telemetry_ = new LCT.Telemetry.Telemetry(TelemetryConstant.Type, new Dictionary<string, string>
3333
{
34-
{ "InstrumentationKey", appSettings.Telemetry.ApplicationInsightInstrumentKey }
34+
{ "InstrumentationKey", appSettings?.Telemetry?.ApplicationInsightInstrumentKey ?? string.Empty }
3535
});
3636
}
3737

src/LCT.PackageIdentifier/ConanProcessor.cs

+12-2
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,18 @@ private static void GetPackagesForBom(ref List<Component> lstComponentForBOM, re
392392

393393
ConanPackage package = nodePackages.Where(x => x.Id == "0").FirstOrDefault();
394394
List<string> directDependencies = new List<string>();
395-
if (package.Dependencies != null) { directDependencies.AddRange(package.Dependencies); }
396-
if (package.DevDependencies != null) { directDependencies.AddRange(package.DevDependencies); }
395+
if (package != null)
396+
{
397+
if (package.Dependencies != null)
398+
{
399+
directDependencies.AddRange(package.Dependencies);
400+
}
401+
402+
if (package.DevDependencies != null)
403+
{
404+
directDependencies.AddRange(package.DevDependencies);
405+
}
406+
}
397407

398408
// Ignoring the root node as it is the package information node and we are anyways considering all
399409
// nodes in the lock file.

src/LCT.PackageIdentifier/MavenProcessor.cs

+4-1
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,10 @@ private static AqlResult GetJfrogArtifactoryRepoDetials(List<AqlResult> aqlResul
383383
aqlResult = aqlResults.FirstOrDefault(x => x.Repo.Equals(repoName));
384384
jfrogRepoPath = GetJfrogRepoPath(aqlResult);
385385
}
386-
aqlResult.Repo ??= repoName;
386+
if (aqlResult != null)
387+
{
388+
aqlResult.Repo ??= repoName;
389+
}
387390
return aqlResult;
388391
}
389392

0 commit comments

Comments
 (0)