Skip to content

Commit 4113b85

Browse files
authored
Merge pull request #121 from siemens/development
Hotfix for JFrog Ref token validation
2 parents ba44628 + a326d0d commit 4113b85

File tree

4 files changed

+19
-21
lines changed

4 files changed

+19
-21
lines changed

.github/workflows/compile.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ jobs:
9595
$sourceFolder = Join-Path $env:GITHUB_WORKSPACE "out" | Join-Path -ChildPath "*"
9696
$outFolder = Join-Path $env:GITHUB_WORKSPACE "out" | Join-Path -ChildPath "continuous-clearing"
9797
New-Item -ItemType Directory -Force -Path $outFolder
98-
$fileName = "continuous-clearing-v6.0.1.zip"
98+
$fileName = "continuous-clearing-v6.0.2.zip"
9999
Write-Host "Filename: '$fileName'"
100100
Write-Host "sourceFolder: '$sourceFolder'"
101101
Write-Host "Outfolder: '$outFolder'"
@@ -139,8 +139,8 @@ jobs:
139139
- name: Create Nuget Packages
140140
id: createNupkg
141141
run: |
142-
nuget pack CA.nuspec -Version 6.0.1
143-
Write-Host "::set-output name=nupkg-LicenseClearingTool::continuous-clearing.6.0.1.nupkg"
142+
nuget pack CA.nuspec -Version 6.0.2
143+
Write-Host "::set-output name=nupkg-LicenseClearingTool::continuous-clearing.6.0.2.nupkg"
144144
145145
- name: Archive NuGet Packages
146146
uses: actions/upload-artifact@v2
@@ -153,9 +153,9 @@ jobs:
153153
id: builddocker
154154
#if: ${{ false }} # disable for now
155155
run: |
156-
docker build . --file Dockerfile --tag ${{ github.repository }}:continuous-clearing-v6.0.1
157-
docker save ${{ github.repository }}:continuous-clearing-v6.0.1 -o continuous-clearing-v6.0.1.tar
158-
Write-Host "::set-output name=docker-LicenseClearingTool::continuous-clearing-v6.0.1.tar"
156+
docker build . --file Dockerfile --tag ${{ github.repository }}:continuous-clearing-v6.0.2
157+
docker save ${{ github.repository }}:continuous-clearing-v6.0.2 -o continuous-clearing-v6.0.2.tar
158+
Write-Host "::set-output name=docker-LicenseClearingTool::continuous-clearing-v6.0.2.tar"
159159
160160
- name: Archive docker image
161161
#if: ${{ false }} # disable for now
@@ -196,8 +196,8 @@ jobs:
196196
env:
197197
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
198198
with:
199-
tag_name: v6.0.1
200-
release_name: Release v6.0.1
199+
tag_name: v6.0.2
200+
release_name: Release v6.0.2
201201
body: |
202202
${{ github.event.head_commit.message }}
203203
draft: true

CA.nuspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<package >
55
<metadata>
66
<id>continuous-clearing</id>
7-
<version>6.0.1</version>
7+
<version>6.0.2</version>
88
<authors>Siemens AG</authors>
99
<owners>continuous-clearing contributors</owners>
1010
<projectUrl>https://github.com/siemens/continuous-clearing</projectUrl>

src/ArtifactoryUploader/ArtifactoryValidator.cs

+9-11
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
using System.Net.Http;
1414
using System.Reflection;
1515
using System.Threading.Tasks;
16+
using System.Net;
1617

1718
namespace LCT.ArtifactoryUploader
1819
{
@@ -27,18 +28,15 @@ public ArtifactoryValidator(NpmJfrogApiCommunication jfrogApiCommunication)
2728
JfrogApiCommunication = jfrogApiCommunication;
2829
}
2930

30-
public async Task ValidateArtifactoryCredentials(CommonAppSettings appSettings)
31-
{
32-
HttpResponseMessage responseMessage = await JfrogApiCommunication.GetApiKey();
33-
string response = await responseMessage.Content.ReadAsStringAsync();
34-
JfrogKey apiKey = JsonConvert.DeserializeObject<JfrogKey>(response);
31+
public async Task ValidateArtifactoryCredentials(CommonAppSettings appSettings)
32+
{
33+
HttpResponseMessage responseMessage = await JfrogApiCommunication.GetApiKey();
3534

36-
bool isValid = apiKey.ApiKey == appSettings.ArtifactoryUploadApiKey;
37-
if (!isValid)
38-
{
39-
Logger.Error("Artifactory Token entered is invalid!");
40-
throw new InvalidDataException($"Invalid Artifactory Token");
41-
}
35+
if (responseMessage.StatusCode != HttpStatusCode.OK)
36+
{
37+
Logger.Error("Artifactory Token entered is invalid!");
38+
throw new InvalidDataException($"Invalid Artifactory Token");
39+
}
4240
}
4341
}
4442
}

src/LCT.Common/appSettings.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// --------------------------------------------------------------------------------------------------------------------
66

77
{
8-
"CaVersion": "6.0.1",
8+
"CaVersion": "6.0.2",
99
"TimeOut": 200,
1010
"ProjectType": "<Insert ProjectType>",
1111
"SW360ProjectName": "<Insert SW360 Project Name>",

0 commit comments

Comments
 (0)